Changes to logging in CVS
I see that recent changes were made in logging/__init__.py to replace the use of "apply(func, args)" with "func(*args)". Doesn't this cause "invalid syntax" problems with 1.5.2? I explicitly coded using apply because I thought it was needed for 1.5.2. There are a few places where I've eschewed use of +=, for the same reason. Any chance we could change back to using apply()? Regards Vinay
Vinay Sajip wrote:
I see that recent changes were made in logging/__init__.py to replace the use of "apply(func, args)" with "func(*args)". Doesn't this cause "invalid syntax" problems with 1.5.2? I explicitly coded using apply because I thought it was needed for 1.5.2. There are a few places where I've eschewed use of +=, for the same reason. Any chance we could change back to using apply()?
You should mark the files you need 1.5.2 compatibility for in the source code. Even though PEP 291 mentions your package, I don't think that everybody knows about this PEP... -- Marc-Andre Lemburg eGenix.com Professional Python Software directly from the Source (#1, Mar 02 2003)
Python/Zope Products & Consulting ... http://www.egenix.com/ mxODBC, mxDateTime, mxTextTools ... http://python.egenix.com/
Python UK 2003, Oxford: 30 days left EuroPython 2003, Charleroi, Belgium: 114 days left
I see that recent changes were made in logging/__init__.py to replace the use of "apply(func, args)" with "func(*args)". Doesn't this cause "invalid syntax" problems with 1.5.2? I explicitly coded using apply because I thought it was needed for 1.5.2. There are a few places where I've eschewed use of +=, for the same reason. Any chance we could change back to using apply()?
You should mark the files you need 1.5.2 compatibility for in the source code. Even though PEP 291 mentions your package, I don't think that everybody knows about this PEP...
Fair enough, but the docstring at the top of __init__.py states: "Should work under Python versions >= 1.5.2, except that source line information is not available unless 'sys._getframe()' is." Do you mean that I need to mention this wherever the source code contains some 1.5.2-constrained idiom like "apply(func, args)" or "a = a + 1", so that it's explicit that it was coded that way for a reason? Regards, Vinay
I see that recent changes were made in logging/__init__.py to replace the use of "apply(func, args)" with "func(*args)". Doesn't this cause "invalid syntax" problems with 1.5.2? I explicitly coded using apply because I thought it was needed for 1.5.2. There are a few places where I've eschewed use of +=, for the same reason. Any chance we could change back to using apply()?
My apologies. I forgot about this. I'll roll it back. --Guido van Rossum (home page: http://www.python.org/~guido/)
participants (3)
-
Guido van Rossum -
M.-A. Lemburg -
Vinay Sajip