I've uploaded a patch for my proposed new 2.4 module cookielib: http://python.org/sf/963318 What next? John
John J Lee wrote:
I've uploaded a patch for my proposed new 2.4 module cookielib:
What next?
Did you already commit to maintain this code for, say, five years? I'm willing to apply this patch as-is (perhaps adding something to whatsnew24). Any objections? Regards, Martin
On Mon, 31 May 2004, [ISO-8859-1] "Martin v. L�wis" wrote:
John J Lee wrote:
I've uploaded a patch for my proposed new 2.4 module cookielib:
What next?
Did you already commit to maintain this code for, say, five years?
Yes.
I'm willing to apply this patch as-is (perhaps adding something to whatsnew24). Any objections?
Not from me <wink>. John
Martin v. Löwis wrote:
I'm willing to apply this patch as-is (perhaps adding something to whatsnew24). Any objections?
None from me. We could probably do with some 'see also' references in related library documentation. -- Anthony Baxter <anthony@interlink.com.au> It's never too late to have a happy childhood.
On Mon, 31 May 2004, Anthony Baxter wrote:
Martin v. Löwis wrote:
I'm willing to apply this patch as-is (perhaps adding something to whatsnew24). Any objections?
None from me. We could probably do with some 'see also' references in related library documentation.
I've already added some to the urllib2 and Cookie docs. I left urllib and httplib's docs alone because I've not added any cookie support for those modules (though there is nothing to prevent that). John
John J Lee wrote:
What next?
I have applied the patch. Now, when I run regrtest, I get test_urllib2 add_cookie_header extract_cookies: Set-Cookie: spam=eggs - checking cookie spam=eggs setting cookie: <Cookie spam=eggs for www.example.com/> add_cookie_header Checking www.example.com for cookies to return - checking cookie path=/ - checking cookie spam=eggs it's a match Can you provide a patch to suppress this output? Regards, Martin
On Mon, 31 May 2004, [ISO-8859-1] "Martin v. L�wis" wrote:
John J Lee wrote:
What next?
I have applied the patch. Now, when I run regrtest, I get [...snip debug output...]
Can you provide a patch to suppress this output?
Whoops, I should never have had a Logger.addHandler() call in there, should I? I've attached a patch to the original SF patch. John
participants (3)
-
"Martin v. Löwis" -
Anthony Baxter -
John J Lee