Hello, I've fed parts of the stdlib to pylint and after some filtering there appears to be some things that looks strange, I've filled a few bugs to the tracker for them. 6623 Lib/ftplib.py netrc class parsing problem 6622 [RFC] wrong variable used in Lib/poplib.py 6621 [RFC] Remove leftover use of Carbon module from Lib/binhex.py 6620 Variable may be used before first being assigned to in Lib/locale.py 6619 Remove duplicated function in Lib/inspect.py Is this useless and taking reviewer's time for nothing ? Please advise, if this is deemed useful, I'll continue further -- Vincent Legoll
On Sat, Aug 1, 2009 at 11:40 PM, Vincent Legoll<vincent.legoll@gmail.com> wrote:
Hello,
I've fed parts of the stdlib to pylint and after some filtering there appears to be some things that looks strange, I've filled a few bugs to the tracker for them.
<buglist snipped>
Is this useless and taking reviewer's time for nothing ?
Please advise, if this is deemed useful, I'll continue further
I think this is valuable work---please do continue! Just out of interest, how many false positives did you have to filter out in finding the 5 cases above? Mark
On Sun, Aug 2, 2009 at 6:20 PM, Mark Dickinson<dickinsm@gmail.com> wrote:
On Sat, Aug 1, 2009 at 11:40 PM, Vincent Legoll<vincent.legoll@gmail.com> wrote:
I've fed parts of the stdlib to pylint and after some filtering there appears to be some things that looks strange, I've filled a few bugs to the tracker for them.
Is this useless and taking reviewer's time for nothing ?
Please advise, if this is deemed useful, I'll continue further
I think this is valuable work---please do continue!
Thanks, I will
Just out of interest, how many false positives did you have to filter out in finding the 5 cases above?
I can't really tell if there was false positives, I just started with the low hanging fruits, the ones I immediately saw as fishy, the remaining I skipped without too much consideration, I think it will take many iterations to do the whole thing. I used a pylint version which is not capable of understanding py3k syntax, so a lot of files were simply skipped. -- Vincent Legoll
participants (2)
-
Mark Dickinson -
Vincent Legoll