I've just logged the small patch to ServerSocket.py into sourceforge that "fixes", or rather makes apparent the bug Bernard had discovered when writing his unit test for the socket module. The fix was simple: in keeping with the style of the module, a member variable was added to the ThreadingMixIn class 'daemon_threads' which decideds whether threads start in daemon mode. Thus to fix the server problem in the previous thread of convo, Bernard needed to do: class ThreadingTCPServer( SocketServer.ThreadingMixIn, MyTCPServer): daemon_threads = 1 for his final version of the server. Or until this patch is accepted, he could subclass off the threadingMixIn class and change the process_request function. The patch is #550765 in SF. -- Mike -- Michael Gilfix mgilfix@eecs.tufts.edu For my gpg public key: http://www.eecs.tufts.edu/~mgilfix/contact.html
Michael Gilfix wrote:
I've just logged the small patch to ServerSocket.py into sourceforge that "fixes", or rather makes apparent the bug Bernard had discovered when writing his unit test for the socket module.
fwiw, the usual meaning of a "patch" is the output from the diff -c command, not a modified copy of the entire file... (see the python-on-sf FAQ for more info) </F>
My mistake. I noticed some patches included the entire file if it was only one file and got lazy. Fixed in the SF tracker. -- Mike On Tue, Apr 30 @ 23:22, Fredrik Lundh wrote:
Michael Gilfix wrote:
I've just logged the small patch to ServerSocket.py into sourceforge that "fixes", or rather makes apparent the bug Bernard had discovered when writing his unit test for the socket module.
fwiw, the usual meaning of a "patch" is the output from the diff -c command, not a modified copy of the entire file...
(see the python-on-sf FAQ for more info)
</F>
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev `-> (fredrik)
-- Michael Gilfix mgilfix@eecs.tufts.edu For my gpg public key: http://www.eecs.tufts.edu/~mgilfix/contact.html
participants (2)
-
Fredrik Lundh
-
Michael Gilfix