Mailman 3 venv scripts for fish and csh shells - Python-Dev

venv scripts for fish and csh shells

older
Re: [Python-Dev] [Python-checkins]...

Andrew Svetlov

19 Jul 2012 19 Jul '12

4:26 p.m.

virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only? -- Thanks, Andrew Svetlov

Show replies by date

Carl Meyer

19 Jul 19 Jul

4:31 p.m.

On 07/19/2012 10:26 AM, Andrew Svetlov wrote:

...

virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only?

No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't commit said patch, so it might be good to hear if Vinay has a different opinion). Carl

Andrew Svetlov

22 Jul 22 Jul

12:12 a.m.

I created http://bugs.python.org/issue15417 with required activation scripts. If there are no objections I like to commit it after, say, three days. On Thu, Jul 19, 2012 at 7:31 PM, Carl Meyer wrote:

...

On 07/19/2012 10:26 AM, Andrew Svetlov wrote:

...
virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only?

No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't commit said patch, so it might be good to hear if Vinay has a different opinion).

Carl

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

-- Thanks, Andrew Svetlov

Georg Brandl

3:21 p.m.

These are new features, please do not commit before 3.3 is released. Georg On 07/22/2012 02:12 AM, Andrew Svetlov wrote:

...

I created http://bugs.python.org/issue15417 with required activation scripts. If there are no objections I like to commit it after, say, three days.

On Thu, Jul 19, 2012 at 7:31 PM, Carl Meyer wrote:

...
On 07/19/2012 10:26 AM, Andrew Svetlov wrote:

...
virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only?

No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't commit said patch, so it might be good to hear if Vinay has a different opinion).

Carl

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

Andrew Svetlov

4:10 p.m.

Georg, sorry, I've committed it before you answered. If you want, I will revert it back. But, please, describe me why those scripts are to late for 3.3? I strongly checked correctness of both activation script for fish and csh/tsch shells. Works fine. It's not *new feature*, it is just extending support to csh and fish shells. Virtualenv (base for venv) already contains this activation scripts. I just converted those files to venv with replacing virtualenv specific environment variables to schema supported by venv. I see nothing bad for adding to venv support for fish and csh as well as already supported bash/zsh Say again, I triple checked correctness of added scripts. With defining VIRTUAL_ENV_DISABLE_PROMPT as well as without it. My addition is safe, trivial, correct and it is not new feature — just fixing of missing support for widely used shells. Anyway. You are Release Manager — the main person for 3.3 release. If you feel what my changes is potentially dangerous and should be removed from 3.3 — I'll do it. But, please, do benevolent. On Sun, Jul 22, 2012 at 6:21 PM, Georg Brandl wrote:

...

These are new features, please do not commit before 3.3 is released.

Georg

On 07/22/2012 02:12 AM, Andrew Svetlov wrote:

...
I created http://bugs.python.org/issue15417 with required activation scripts. If there are no objections I like to commit it after, say, three days.

On Thu, Jul 19, 2012 at 7:31 PM, Carl Meyer wrote:

...
On 07/19/2012 10:26 AM, Andrew Svetlov wrote:

...
virtualenv has virtualenv.csh and virtualenv.fish files. Is there any reason for restricting venv to bash/zsh only?

No. As far as I'm concerned, a patch to port the virtualenv csh and fish activate scripts to pyvenv would be welcome (though I can't commit said patch, so it might be good to hear if Vinay has a different opinion).

Carl

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

-- Thanks, Andrew Svetlov

Georg Brandl

4:50 p.m.

On 07/22/2012 06:10 PM, Andrew Svetlov wrote:

...

Georg, sorry, I've committed it before you answered.

After you wrote that you'd wait three days... anyway, I can't find the commit in the repository, so that's fine.

...

If you want, I will revert it back. But, please, describe me why those scripts are to late for 3.3? I strongly checked correctness of both activation script for fish and csh/tsch shells. Works fine.

"Works fine" is not good enough. There are hundreds of potential patches on the tracker implementing new features of which the same could be said.

...

It's not *new feature*, it is just extending support to csh and fish shells.

That is a new feature in my view. If it was an important feature, someone would have thought of it while features were allowed.

...

Virtualenv (base for venv) already contains this activation scripts. I just converted those files to venv with replacing virtualenv specific environment variables to schema supported by venv. I see nothing bad for adding to venv support for fish and csh as well as already supported bash/zsh

Say again, I triple checked correctness of added scripts. With defining VIRTUAL_ENV_DISABLE_PROMPT as well as without it. My addition is safe, trivial, correct and it is not new feature — just fixing of missing support for widely used shells.

Anyway. You are Release Manager — the main person for 3.3 release. If you feel what my changes is potentially dangerous and should be removed from 3.3 — I'll do it. But, please, do benevolent.

The point of feature freeze is that there are no new features. Where can I draw the line, when everybody argues like that and I agree? Georg

Andrew Svetlov

5:39 p.m.

Ok. Sorry for my mistake — there are really no commits for http://bugs.python.org/issue15417 It's look important for me — but you are release manager. If you consider the patch as potentially dangerous — I have to agree with you. You are the master :) On Sun, Jul 22, 2012 at 7:50 PM, Georg Brandl wrote:

...

On 07/22/2012 06:10 PM, Andrew Svetlov wrote:

...
Georg, sorry, I've committed it before you answered.

After you wrote that you'd wait three days... anyway, I can't find the commit in the repository, so that's fine.

...
If you want, I will revert it back. But, please, describe me why those scripts are to late for 3.3? I strongly checked correctness of both activation script for fish and csh/tsch shells. Works fine.

"Works fine" is not good enough. There are hundreds of potential patches on the tracker implementing new features of which the same could be said.

...
It's not *new feature*, it is just extending support to csh and fish shells.

That is a new feature in my view. If it was an important feature, someone would have thought of it while features were allowed.

...
Virtualenv (base for venv) already contains this activation scripts. I just converted those files to venv with replacing virtualenv specific environment variables to schema supported by venv. I see nothing bad for adding to venv support for fish and csh as well as already supported bash/zsh

Say again, I triple checked correctness of added scripts. With defining VIRTUAL_ENV_DISABLE_PROMPT as well as without it. My addition is safe, trivial, correct and it is not new feature — just fixing of missing support for widely used shells.

Anyway. You are Release Manager — the main person for 3.3 release. If you feel what my changes is potentially dangerous and should be removed from 3.3 — I'll do it. But, please, do benevolent.

The point of feature freeze is that there are no new features. Where can I draw the line, when everybody argues like that and I agree?

Georg

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

-- Thanks, Andrew Svetlov

Antoine Pitrou

5:54 p.m.

On Sun, 22 Jul 2012 20:39:15 +0300 Andrew Svetlov wrote:

...

Ok. Sorry for my mistake — there are really no commits for http://bugs.python.org/issue15417 It's look important for me — but you are release manager. If you consider the patch as potentially dangerous — I have to agree with you. You are the master :)

This is not because Georg is the master. When a release is nearing we think it is important to avoid introducing potential regressions, except when fixing existing bugs. That's why we have a feature freeze which extends to many kinds of "enhancements", including performance improvements: really, it is more of a "bugfix-only period". One could propose other mechanisms for release preparation, but in the meantime, it is important as a community that we all follow similar rules. Regards Antoine. -- Software development and contracting: http://pro.pitrou.net

Andrew Svetlov

23 Jul 23 Jul

4:24 p.m.

I thought my proposition is minor change, but if it's too late for 3.3 — I'm ok. On Sun, Jul 22, 2012 at 8:54 PM, Antoine Pitrou wrote:

...

On Sun, 22 Jul 2012 20:39:15 +0300 Andrew Svetlov wrote:

...
Ok. Sorry for my mistake — there are really no commits for http://bugs.python.org/issue15417 It's look important for me — but you are release manager. If you consider the patch as potentially dangerous — I have to agree with you. You are the master :)

This is not because Georg is the master. When a release is nearing we think it is important to avoid introducing potential regressions, except when fixing existing bugs. That's why we have a feature freeze which extends to many kinds of "enhancements", including performance improvements: really, it is more of a "bugfix-only period".

One could propose other mechanisms for release preparation, but in the meantime, it is important as a community that we all follow similar rules.

Regards

Antoine.

-- Software development and contracting: http://pro.pitrou.net

_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/andrew.svetlov%40gmail.com

-- Thanks, Andrew Svetlov

Brian Curtin

4:34 p.m.

On Mon, Jul 23, 2012 at 11:24 AM, Andrew Svetlov wrote:

...

I thought my proposition is minor change, but if it's too late for 3.3 — I'm ok.

Very simply, the first beta is when feature freeze goes into effect. This is a really common policy that has been in effect for a long time in CPython and most projects.

4294

Age (days ago)

4298

Last active (days ago)

List overview

Download

9 comments

5 participants

participants (5)

Andrew Svetlov
Antoine Pitrou
Brian Curtin
Carl Meyer
Georg Brandl

venv scripts for fish and csh shells

tags

participants (5)