Minor cookielib changes for 2.4b1

Would anyone care to check this cookielib.py patch in before 2.4b1? http://python.org/sf/1028908 Quote from above: The patch contains uncontroversial changes to cookielib and associated modules, documentation and tests. Would be unfortunate not to have these in 2.4.0. [...SNIP...] John

John J Lee wrote:
The patch contains uncontroversial changes to cookielib and associated modules, documentation and tests. Would be unfortunate not to have these in 2.4.0.
What precisely makes these changes uncontroversial? The fact that no controversion has been developed? At this point, only bug fixes are likely not to cause any controversion. For feature changes (such as the changes to the domain processing), I would need to see examples of what precisely the change is, e.g. by presenting an input to which the output will be different, preferably with an identification of the old and the new output and a reasoning why the new output is better. Regards, Martin

The patch contains uncontroversial changes to cookielib and associated modules, documentation and tests. Would be unfortunate not to have
John J Lee wrote: these
in 2.4.0.
[Martin]
What precisely makes these changes uncontroversial? The fact that no controversion has been developed?
I've looked over the patch and think most of it should wait until Py2.5. Refactorings of this magnitude should be done early in the development cycle to allow time to discover and fix issues if something gets mucked up. A couple of the doc changes should probably go in for Py2.4b2 (a note on thread safety and an example of how to display debugging information). If no one objects, I'll put those in after the beta. Also there is a minor readability fix (using escape sequences) for the test suite that is reasonable for Py2.4. Raymond

Raymond Hettinger wrote:
A couple of the doc changes should probably go in for Py2.4b2 (a note on thread safety and an example of how to display debugging information). If no one objects, I'll put those in after the beta. Also there is a minor readability fix (using escape sequences) for the test suite that is reasonable for Py2.4.
Applying these doc changes is fine with me. I'm not always sure they are improvements (they don't make things worse, either) - but then, I'm not a native speaker, so not really qualified to judge them. Regards, Martin

Sorry for not replying earlier: I've not been well. On Fri, 15 Oct 2004, Raymond Hettinger wrote:
The patch contains uncontroversial changes to cookielib and associated modules, documentation and tests. Would be unfortunate not to have
John J Lee wrote: these
in 2.4.0.
[Martin]
What precisely makes these changes uncontroversial? The fact that no controversion has been developed?
My attempt at time-travel was unsuccessful, sorry. :-)
I've looked over the patch and think most of it should wait until Py2.5. Refactorings of this magnitude should be done early in the development cycle to allow time to discover and fix issues if something gets mucked up.
Hadn't realised how late it was.
A couple of the doc changes should probably go in for Py2.4b2 (a note on thread safety and an example of how to display debugging information). If no one objects, I'll put those in after the beta. Also there is a minor readability fix (using escape sequences) for the test suite that is reasonable for Py2.4.
Thanks, Raymond. John
participants (4)
-
"Martin v. Löwis"
-
Anthony Baxter
-
John J Lee
-
Raymond Hettinger