Threading bug review + commit privs
Hey all, I'm porting some fixes for threading.py that we applied to unladen-swallow: http://bugs.python.org/issue6643 We ran into these bizarre race conditions involving fork + threads while running the test suite with a background JIT compilation thread. I really wish we weren't trying to support forking from a child thread, but it's already in the test suite. I've "solved" the problem by throwing away radioactive locks that may have been held across a fork.* If I could get a reviewer to look at this, I would be very grateful, since reviewing threading patches is somewhat tricky. =/ I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that. Thanks, Reid * In general I wouldn't think this is safe, but we already do it for _active_limbo_lock in threading.py. One of the problems I've encountered is that on OS X, releasing locks held by other threads across a fork results in a crash. Furthermore, when locks are deallocated, the destructor does a non-blocking acquire and then release, which I would think would crash. However, we get lucky here, because any thread that holds a lock across a fork usually holds a reference to it on the stack. Therefore the lock is leaked and the destructor never run. Moral: fork + threads is *crazy*, avoid it if you can.
On Sun, 11 Jul 2010 13:23:13 +0000 Reid Kleckner <reid.kleckner@gmail.com> wrote:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
It sounds good to me. Also, thanks for your threading patches! Regards Antoine.
On Sun, Jul 11, 2010 at 09:28, Antoine Pitrou <solipsis@pitrou.net> wrote:
On Sun, 11 Jul 2010 13:23:13 +0000 Reid Kleckner <reid.kleckner@gmail.com> wrote:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
It sounds good to me. Also, thanks for your threading patches!
+1 from me as well.
On Sun, Jul 11, 2010 at 9:28 AM, Antoine Pitrou <solipsis@pitrou.net> wrote:
On Sun, 11 Jul 2010 13:23:13 +0000 Reid Kleckner <reid.kleckner@gmail.com> wrote:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
It sounds good to me. Also, thanks for your threading patches!
+1 from me.
On Sun, Jul 11, 2010 at 9:28 AM, Antoine Pitrou <solipsis@pitrou.net> wrote:
On Sun, 11 Jul 2010 13:23:13 +0000 Reid Kleckner <reid.kleckner@gmail.com> wrote:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
It sounds good to me. Also, thanks for your threading patches!
Regards
+1
Thanks for the support! Georg Brandl authorized my SSH keys for SVN access. Reid On Tue, Jul 13, 2010 at 7:29 AM, Gregory P. Smith <greg@krypto.org> wrote:
On Sun, Jul 11, 2010 at 9:28 AM, Antoine Pitrou <solipsis@pitrou.net> wrote:
On Sun, 11 Jul 2010 13:23:13 +0000 Reid Kleckner <reid.kleckner@gmail.com> wrote:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
It sounds good to me. Also, thanks for your threading patches!
Regards
+1
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/reid.kleckner%40gmail.com
Am 11.07.2010 15:23, schrieb Reid Kleckner:
I'm also expecting to be doing more work merging unladen-swallow into the py3k-jit branch, so I was wondering if I could get commit privileges for that.
Sure -- send your public key to me, and I'll set you up. Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.
participants (6)
-
Antoine Pitrou -
Brett Cannon -
Collin Winter -
Georg Brandl -
Gregory P. Smith -
Reid Kleckner