test_zlib.py suggestion
I have a build_bot running (yeah me!), and was surprised to see test_zlib fail on AIX. There is not an issue with test_zlib, but I do have a suggestion. I was getting an error with test_flushes(). On python2-2.7.15 the test passes and in python3-3.8 (and earlier I expect) the test fails. The difference is the addition of the two modes 'Z_PARTIAL_FLUSH' and 'Z_BLOCK' sync_opt = ['Z_NO_FLUSH', 'Z_SYNC_FLUSH', 'Z_FULL_FLUSH', 'Z_PARTIAL_FLUSH', 'Z_BLOCK'] On default AIX installs zlib is, sadly, still at version 1.2.3 and Z_BLOCK was 'improved' in version 1.2.5. And it fails on Z_BLOCK. My suggestion is to enhance the test_library_version() so that it verifies that the minor (or smaller?) number is at least '5' When I static link python with zlib-1.2.11 then the test_zlib passes all sub-tests. Again, not a python bug - but a suggestion for improving what is tested. I can open an issue, and with a bit of assistance/interest from others I'll even do a PR. Michael
Open an issue as this will surely get forgotten otherwise, then people can discuss on the issue how to handle this. On Wed, 1 Aug 2018 at 08:40 Michael <aixtools@felt.demon.nl> wrote:
I have a build_bot running (yeah me!), and was surprised to see test_zlib fail on AIX.
There is not an issue with test_zlib, but I do have a suggestion.
I was getting an error with test_flushes(). On python2-2.7.15 the test passes and in python3-3.8 (and earlier I expect) the test fails. The difference is the addition of the two modes 'Z_PARTIAL_FLUSH' and 'Z_BLOCK'
sync_opt = ['Z_NO_FLUSH', 'Z_SYNC_FLUSH', 'Z_FULL_FLUSH', 'Z_PARTIAL_FLUSH', 'Z_BLOCK']
On default AIX installs zlib is, sadly, still at version 1.2.3 and Z_BLOCK was 'improved' in version 1.2.5. And it fails on Z_BLOCK.
My suggestion is to enhance the test_library_version() so that it verifies that the minor (or smaller?) number is at least '5'
When I static link python with zlib-1.2.11 then the test_zlib passes all sub-tests.
Again, not a python bug - but a suggestion for improving what is tested.
I can open an issue, and with a bit of assistance/interest from others I'll even do a PR.
Michael
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/brett%40python.org
On 01/08/2018 18:03, Brett Cannon wrote:
Open an issue as this will surely get forgotten otherwise, then people can discuss on the issue how to handle this. Will do. I have more homework - as I just tested AIX 7.1 TL5 as a build system. The good news is libz.a is finally updated to something newer. The bad news is they introduced libreadline-6, with no support, and that it seems it going to be difficult to get it to link.
I so wish they would include "include files" with these standard libraries. Not doing so is one of the reasons things break - either double files, overwriting files and/or mixed versions. Sigh.
On Wed, 1 Aug 2018 at 08:40 Michael <aixtools@felt.demon.nl> wrote:
I have a build_bot running (yeah me!), and was surprised to see test_zlib fail on AIX.
There is not an issue with test_zlib, but I do have a suggestion.
I was getting an error with test_flushes(). On python2-2.7.15 the test passes and in python3-3.8 (and earlier I expect) the test fails. The difference is the addition of the two modes 'Z_PARTIAL_FLUSH' and 'Z_BLOCK'
sync_opt = ['Z_NO_FLUSH', 'Z_SYNC_FLUSH', 'Z_FULL_FLUSH', 'Z_PARTIAL_FLUSH', 'Z_BLOCK']
On default AIX installs zlib is, sadly, still at version 1.2.3 and Z_BLOCK was 'improved' in version 1.2.5. And it fails on Z_BLOCK.
My suggestion is to enhance the test_library_version() so that it verifies that the minor (or smaller?) number is at least '5'
When I static link python with zlib-1.2.11 then the test_zlib passes all sub-tests.
Again, not a python bug - but a suggestion for improving what is tested.
I can open an issue, and with a bit of assistance/interest from others I'll even do a PR.
Michael
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/brett%40python.org
participants (2)
-
Brett Cannon -
Michael