Old bug still unfixed? [ python-Patches-1183712 ] package_data chops off first char of default package
Hi! (I first posted this to distutils-sig but was told that distutils is a bit neglected there, so I decided to try to push these simple patches in via python-dev.) Lately, a student came to me complaining about an old distutils bug which bit him: http://mail.python.org/pipermail/patches/2006-August/020642.html The patch is quite trivial and cannot possibly break something AFAICS, so could someone please apply it? (Hmm, now that I write this; we are still using python 2.4.4 here, so maybe it has been fixed in between?) Ciao, / / /--/ / / ANS
Hans Meine schrieb:
(I first posted this to distutils-sig but was told that distutils is a bit neglected there, so I decided to try to push these simple patches in via python-dev.) Lately, a student came to me complaining about an old distutils bug which bit him: http://mail.python.org/pipermail/patches/2006-August/020642.html
The patch is quite trivial and cannot possibly break something AFAICS, so could someone please apply it? (Hmm, now that I write this; we are still using python 2.4.4 here, so maybe it has been fixed in between?)
See https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1183712&group_id=5470 The last comment is from jimjjewet, and he claims that the patch is still incomplete. There is no response to that claim so far, by either the patch author nor anybody else. I still believe that the patch is unnecessary, i.e. it fixes a problem which shouldn't arise in the first place. Regards, Martin
At 10:35 PM 2/23/2007 +0100, Martin v. Löwis wrote:
Hans Meine schrieb:
(I first posted this to distutils-sig but was told that distutils is a bit neglected there, so I decided to try to push these simple patches in via python-dev.) Lately, a student came to me complaining about an old distutils bug which bit him: http://mail.python.org/pipermail/patches/2006-August/020642.html
The patch is quite trivial and cannot possibly break something AFAICS, so could someone please apply it? (Hmm, now that I write this; we are still using python 2.4.4 here, so maybe it has been fixed in between?)
See
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1183712&group_id=5470
The last comment is from jimjjewet, and he claims that the patch is still incomplete. There is no response to that claim so far, by either the patch author nor anybody else. I still believe that the patch is unnecessary, i.e. it fixes a problem which shouldn't arise in the first place.
I believe you're correct. If anything, the fix should be to disallow an empty string being listed in the 'packages' argument to 'setup()'. I've added some notes to the bug to also show why Jim's concerns about absolute paths and trailing /'s don't actually come into play for this code.
participants (3)
-
"Martin v. Löwis" -
Hans Meine -
Phillip J. Eby