Request for patch review
I've worked on two patches for NeedForSpeed, and would like someone familiar with the areas they touch to review them before I check them in, breaking all the buildbots which aren't broken yet ;) They are: http://python.org/sf/1346214 Better dead code elimination for the AST compiler http://python.org/sf/921466 Reduce number of open calls on startup GB Thanks! Georg
Georg Brandl wrote:
I've worked on two patches for NeedForSpeed, and would like someone familiar with the areas they touch to review them before I check them in, breaking all the buildbots which aren't broken yet ;)
They are:
http://python.org/sf/1346214 Better dead code elimination for the AST compiler
No one wants to look at this? It's not too complicated, I promise.
http://python.org/sf/921466 Reduce number of open calls on startup GB
That's now committed. Georg
On 6/3/06, Georg Brandl
Georg Brandl wrote:
I've worked on two patches for NeedForSpeed, and would like someone familiar with the areas they touch to review them before I check them in, breaking all the buildbots which aren't broken yet ;)
They are:
http://python.org/sf/1346214 Better dead code elimination for the AST compiler
No one wants to look at this? It's not too complicated, I promise.
Well, "wants' is a strong word. =) Code looks fine (didn't apply it, but looked at the patch file itself). I would break the detection for 'return' in generators into a separate patch since it has nothing to do with detection of dead code. -Brett
Reduce number of open calls on startup GB
That's now committed.
Georg
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/brett%40python.org
participants (2)
-
Brett Cannon
-
Georg Brandl