On 23.03.2013 13:18, Antoine Pitrou wrote:
On Fri, 22 Mar 2013 15:42:49 -0700 "Gregory P. Smith" firstname.lastname@example.org wrote:
On Fri, Mar 22, 2013 at 3:31 PM, Ronny Pfannschmidt < Ronny.Pfannschmidt@gmx.de> wrote:
while reviewing urllib.parse i noticed a pretty ugly pattern
many functions had an attached global and in their own code they would compile an regex on first use and assign it to that global
its clear that compiling a regex is expensive, so having them be compiled later at first use would be of some benefit
It isn't expensive to do, it is expensive to do repeatedly for no reason. Thus the use of compiled regexes. Code like this would be better off refactored to reference a precompiled global rather than conditionally check if it needs compiling every time it is called.
In the stdlib we should be rather careful about this. Third-party libraries can ignore such concerns if they aren't meant to use in interactive applications.
Wouldn't it make sense to add a way to pickle or marshal compiled REs ?
The precompiled REs could then be loaded directly from the pickle, avoiding the compiling overhead on startup.