i used uv_events as default event loop and ran all tulip tests with it. but those failures are not related to uv_events anyway I'd inherit uv_events.EventLoop from base_events.BaseEventLoop. On Feb 5, 2013, at 3:56 PM, Saúl Ibarra Corretgé <saghul@gmail.com> wrote:
Nikolay Kim wrote:
On Feb 5, 2013, at 2:58 PM, Guido van Rossum<guido@python.org> wrote:
On Tue, Feb 5, 2013 at 2:35 PM, Saúl Ibarra Corretgé<saghul@gmail.com> wrote:
I just updated rose [0] to match latest changes in Tulip API and remove Tulip itself from the code, now a proper EventLoopPolicy is defined, which will in turn use the pyuv-based event loop. Neat!
I wonder if you could see how many of Tulip's own tests pass with your event loop implementation?
Hum, they all pass for me on OSX. Did you use the runtests.py script from rose?
two tests are failing. i think thats very good result.
====================================================================== FAIL: test_start_serving_cant_bind (tulip.events_test.UVEventLoopTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/unittest/mock.py", line 1088, in patched return func(*args, **keywargs) File "/Users/nikolay/dev/tulip/src/tulip/tulip/events_test.py", line 497, in test_start_serving_cant_bind self.assertRaises(Err, self.event_loop.run_until_complete, fut) AssertionError: Err not raised by run_until_complete
I overwrote this test in rose/events_test.py
====================================================================== FAIL: test_baseexception_during_cancel (tulip.tasks_test.TaskTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/nikolay/dev/tulip/src/tulip/tulip/tasks_test.py", line 451, in test_baseexception_during_cancel self.assertRaises(BaseException, self.event_loop.run_once) AssertionError: BaseException not raised by run_once
Hum, I have not seen this one.
-- Saúl Ibarra Corretgé http://saghul.net/blog | http://about.me/saghul