On Thu, 24 Sep 2020 at 22:22, Guido van Rossum <guido@python.org> wrote:
- I recommend that you carefully look over the PEP as rendered on python.org (link above) and try to fix any markup oddities. E.g. some comments are line-wrapped, which looks ugly, and some bulleted lists have an extra blank line above.
- Looking at the generated ToC, you have two top-level sections labeled "Syntax and Semantics". That seems a bit odd. I'm not sure what you meant to happen here, but I recommend renaming at least one of these. (Another recommendation: don't mix description of the status quo with the specification.)
No matter how many times one re-reads something, there's always going to be a typo :) Just as a question, the generated html using make pep-0637.html are not supposed to get the css style. I get no stylisation, but I do see a .css file. Code seems to support that css is only there to be pushed to remote deployment, but maybe there's a trick I haven't spotted.
- While I can understand the desire to keep C function names short, I don't see we should continue the tradition of using the meaningless 'Ex' suffix for API variations that take an additional dict of keywords. Looking through the existing APIs, I recommend PyObject_{Get,Set,Del}ItemWithKeywords instead. (Note you have a typo here, "DetItem". Also I recommend adding markup (e.g. bullets) so each signature is on a line by itself.
Will do. Thanks. In fact I'll focus tonight on fixing the visual aspect and typos. I also have feedback from the numpy mailing list about the argument to pass in case no positional index is specified), but I'll add that later, as well as the rest of this ml feedback. I also tried to start implementing the feature as a PoC... but the parser grammar is beyond my skills I fear. I understand it, but unsure (at the moment) how to modify it. Nevertheless I am willing to spend some days and do some experiments. I'll keep you all posted if I can achieve something that seems to work. -- Kind regards, Stefano Borini