Antoine Pitrou schrieb:
Guido van Rossum <guido@...> writes:
But the merges into the core will be tough. Imagine submitting a 5000-line patch and saying "I've worked on this for a year, please adopt it." Will we do enough code review to assert the code quality?
Pardon for hijacking the moratorium discussion, but this is the kind of problem we already have with externally-maintained modules (such as json). The way they are updated is that once in a while (once a year perhaps), their author comes with a huge patch that we should ideally review, except that it's very difficult to do so -- especially given that it's about a piece of code that we don't know well in the first place.
But we haven't really put a review policy into place for core commits, and since the authors of those packages all (?) are core devs, we trust them enough to commit to the core. It's different with DVCS branches created by "only" community members.
PS. My elbow needs a couple more weeks of rest. Limiting myself to ultra-short emails.
I hope you'll get better soon!
+1. Georg -- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.