On Tue, Oct 10, 2017 at 5:46 PM, Yury Selivanov firstname.lastname@example.org wrote:
On Tue, Oct 10, 2017 at 10:22 AM, Koos Zevenhoven email@example.com wrote:
On Tue, Oct 10, 2017 at 5:01 PM, Nick Coghlan firstname.lastname@example.org wrote: >
On 10 October 2017 at 22:51, Koos Zevenhoven email@example.com wrote: >
I see no reason why these two should be equivalent.
There is no "should" about it: it's a brute fact that the two forms are currently equivalent for lazy iterators (including generators), and both different from the form that uses eager evaluation of the values before the context change.
Where should enters into the picture is by way of PEP 550 saying that they should remain equivalent because we don't have an adequately compelling justification for changing the runtime semantics.
That is, given the following code:
itr = make_iter() with decimal.localcontext() as ctx: ctc.prex = 30 for i in itr: pass
Right now, today, in 3.6. the calculations in the iterator will use the modified decimal context, not the context that applied when the iterator was created. If you want to ensure that isn't the case, you have to force eager evaluation before the context change.
It is not obvious to me if changing the semantics of this is breakage or a bug fix (as you put it below).
What PEP 550 is proposing is that, by default, nothing changes: the lazy iteration in the above will continue to use the updated decimal context by default.
That's just an arbitrary example. There are many things that would change if decimal contexts simply switched from using thread-local storage to using PEP 550. It's not at all obvious which of the changes would be most likely to cause problems. If I were to choose, I would probably introduce a new context manager which works with PEP 555 semantics, because that's the only way to ensure full backwards compatibility, regardless of whether PEP 555 or PEP 550 is used. But I'm sure one could decide otherwise.
Please stop using "many things .. would", "most likely" etc.
I can't explain everything, especially not in a single email. I will use whatever English words I need. You can also think for yourself––or ask a question.
We have a very focused discussion here. If you know of any particular issue, please demonstrate it with a realistic example. Otherwise, we only increase the number of emails and make things harder to track for everybody.
I'm not going to (and won't be able to) list all those many use cases. I'd
like to keep this more focused too. I'm sure you are well aware of those
differences. It's not up to me to decide what
decimal should do.
I'll give you some examples below, if that helps.
If decimal switches to use PEP 550, there will be no "many things that would change". The only thing that will change is this:
def g(): with decimal_context(...): yield
next(g()) # this will no longer leak decimal context to the outer world
yield from g(). See also below.
I consider the above a bug fix, because nobody in their right mind relies on partial iteration of generator expecting that some of it's internal code would affect your code indirectly.
People use generators for all kinds of things. See below.
The only such case is contextlib.contextmanager, and PEP 550 provides mechanisms to make generators "leaky" explicitly.
That's not the only one.
Here's another example:
def context_switcher(): for c in contexts: decimal.setcontext(c) yield ctx_switcher = context_switcher()
def next_context(): next(ctx_switcher)
And one more example:
def make_things(): old_ctx = None def first_things_first(): first = compute_first_value() yield first
ctx = figure_out_context(first) nonlocal old_ctx old_ctx = decimal.getcontext() decimal.setcontext(ctx) yield get_second_value() def the_bulk_of_things(): return get_bulk() def last_but_not_least(): decimal.set_context(old_ctx) yield "LAST" yield from first_things_first() yield from the_bulk_of_things() yield from last_but_not_least()
all_things = list(make_things())