On Tue, May 4, 2021 at 5:16 AM Caleb Donovick <donovick@cs.stanford.edu> wrote:
For the record I am definitely a -1 on this. The arguments against are overwhelming and the arguments for are pretty weak. However I felt the need to rebut:
Tests don't really count, so there's a small handful here.
Tests 100% count as real use cases. If this is a pattern that would be useful in test case generation then we should be discussing that. I have worked on plenty of projects which were almost exclusively documented through tests. Being able to read and write tests fluently is as important as any other piece of code.
That's true, but in many cases, tests are there to test specific functionality. Since no functionality is being removed, anything that's testing str.join() will need to continue testing str.join(). I didn't dig into the specific examples to see which ones were testing str.join and which ones happened to be using str.join to test something else. ChrisA