On Mon, Mar 30, 2009 at 2:28 PM, Nick Coghlan <ncoghlan@gmail.com> wrote:
Mart Sõmermaa wrote:
> Right you are, sorry for the mental blunder. So what if the signature is
> as follows to support passing query parameters via an ordered dict:
>
> add_query_params(url, params_dict=None, **kwargs)
>
> with the following behaviour:
>
>>>> pd = odict()
>>>> pd['a'] = 1
>>>> pd['b'] = 2
>>>> add_query_params('http://foo.com/?a=0', pd, a=3)
> 'http://foo.com/?a=0&a=1&b=2&a=3 <http://foo.com/?a=0&a=1&b=2&a=3>'

When setting up a dict.update style interface like that, it is often
better to use *args for the two positional arguments - it avoids
accidental name conflicts between the positional arguments and arbitrary
keyword arguments.

Thanks, another good point.