![](https://secure.gravatar.com/avatar/7891e967a711f4b2c9fac20dedc64654.jpg?s=120&d=mm&r=g)
Robert Collins wrote:
Is it API compatible with the current zipfile module docs?
Yes it should be (that was my intention during the refactor and if I accidentally introduced an incompatibility, I'll fix that up before I attempt to integrate the work). I had a look through the docs again and I can't see any incompatibilities. The zipfile module's test suite is currently passing against the repo too. I forked the tests into the repo to use as a basis for this work. On Tue, Jun 4, 2019 at 7:24 AM Steve Barnes <GadgetSteve@live.co.uk> wrote:
One specific pain point with zipfile is that if you zip a directory that contains the target zip file you end up trying to add the target file to itself which leads to a rapidly growing archive.
I think this could be another Python-ideas itself as it could be implemented without a refactor and there is already a lot going on in the refactor at the moment. Cheers, Dan