On Sun, Apr 19, 2020 at 3:37 AM Alex Hall <alex.mojaki@gmail.com> wrote:
```
File "setup.py", line 2232
        self.add(Extension('_decimal',
                           include_dirs=include_dirs,
                           libraries=libraries,
                           define_macros=define_macros,
                           undef_macros=undef_macros,
                           extra_compile_args=extra_compile_args,
                           sources=sources,
                           depends=depends))

I don't know about all the other examples, but in a setup.py that cries out for a more declarative approach: put all that in a dict, and call Extension('_decimal', **build_params).

In general, I think setup.py modules should be a lot for declarative anyway, but at a glance, that sure looks like you'd have the same set for multiple extensions.

I suspect that quite a few of the cases where folks are doing a lot of same-name kwargs passing could hve been better written with an intermediate dict. I'm not saying I don't do it myself, but honestly, it's a bit out of lazyness -- so I'm thinking that new syntax that encourages this style might be a bad idea.

-CHB



--
Christopher Barker, PhD

Python Language Consulting
  - Teaching
  - Scientific Software Development
  - Desktop GUI and Web Development
  - wxPython, numpy, scipy, Cython