A nice __repr__ for the ast.* classes?
Wouldn't it be nice if this
import ast print repr(ast.parse("(1 + 1)").body[0].value) <_ast.BinOp object at 0x0000000001E94B38>
printed something more useful?
print repr(ast.parse("(1 + 1)").body[0].value) BinOp(left=Num(n=1), op=Add(), right=Num(n=1))
I've been doing some work on macropy <https://github.com/lihaoyi/macropy>, which uses the ast.* classes extensively, and it's annoying that we have to resort to dirty-tricks like monkey-patching the AST classes (for CPython 2.7) or even monkey-patching __builtin__.repr (to get it working on PyPy) just to get eval(repr(my_ast)) == my_ast to hold true. And a perfectly good solution already exists in the ast.dump() method, too! (It would also be nice if "==" did a structural comparison on the ast.* classes too, but that's a different issue). -Haoyi
But do you really want it to print the entire parse tree even if it represents several pages of code? On Tue, Apr 30, 2013 at 6:12 PM, Haoyi Li <haoyi.sg@gmail.com> wrote:
Wouldn't it be nice if this
import ast print repr(ast.parse("(1 + 1)").body[0].value) <_ast.BinOp object at 0x0000000001E94B38>
printed something more useful?
print repr(ast.parse("(1 + 1)").body[0].value) BinOp(left=Num(n=1), op=Add(), right=Num(n=1))
I've been doing some work on macropy, which uses the ast.* classes extensively, and it's annoying that we have to resort to dirty-tricks like monkey-patching the AST classes (for CPython 2.7) or even monkey-patching __builtin__.repr (to get it working on PyPy) just to get
eval(repr(my_ast)) == my_ast
to hold true. And a perfectly good solution already exists in the ast.dump() method, too! (It would also be nice if "==" did a structural comparison on the ast.* classes too, but that's a different issue).
-Haoyi
_______________________________________________ Python-ideas mailing list Python-ideas@python.org http://mail.python.org/mailman/listinfo/python-ideas
-- --Guido van Rossum (python.org/~guido)
On 01/05/13 11:21, Guido van Rossum wrote:
But do you really want it to print the entire parse tree even if it represents several pages of code?
Large dicts have the same problem. I can't tell you the number of times I've printed an apparently innocent dict that happened to have builtins in it. I don't think there's any good solution to this. My feeling is that the usefulness of small {dicts | parse trees} having a nice repr outweighs the inconvenience of large ones having a big repr, but I would understand if others had a different opinion. -- Steven
Isn't that the distinction between repr() and str()? That repr() is generally (to a greater extent) meant to return eval()-able code, while str() is just something nice to look at. I don't think the # of pages it outputs should really matter, if the thing you are printing really is that big. It won't be much bigger than printing big lists or dicts, and we happily let those cause the terminal to scroll for minutes at a time if we accidentally print them. The default behavior (e.g. when you print() it or string-interpolate it) would still give you something short and nice to look at. Presumably when someone called repr() instead of str(), he was hoping for some sort of eval()-able code snippet. On Tue, Apr 30, 2013 at 6:21 PM, Guido van Rossum <guido@python.org> wrote:
But do you really want it to print the entire parse tree even if it represents several pages of code?
Wouldn't it be nice if this
import ast print repr(ast.parse("(1 + 1)").body[0].value) <_ast.BinOp object at 0x0000000001E94B38>
printed something more useful?
print repr(ast.parse("(1 + 1)").body[0].value) BinOp(left=Num(n=1), op=Add(), right=Num(n=1))
I've been doing some work on macropy, which uses the ast.* classes extensively, and it's annoying that we have to resort to dirty-tricks
On Tue, Apr 30, 2013 at 6:12 PM, Haoyi Li <haoyi.sg@gmail.com> wrote: like
monkey-patching the AST classes (for CPython 2.7) or even monkey-patching __builtin__.repr (to get it working on PyPy) just to get
eval(repr(my_ast)) == my_ast
to hold true. And a perfectly good solution already exists in the ast.dump() method, too! (It would also be nice if "==" did a structural comparison on the ast.* classes too, but that's a different issue).
-Haoyi
_______________________________________________ Python-ideas mailing list Python-ideas@python.org http://mail.python.org/mailman/listinfo/python-ideas
-- --Guido van Rossum (python.org/~guido)
On Wed, May 1, 2013 at 11:35 AM, Haoyi Li <haoyi.sg@gmail.com> wrote:
Isn't that the distinction between repr() and str()? That repr() is generally (to a greater extent) meant to return eval()-able code, while str() is just something nice to look at.
The stronger distinction is that repr() is ideally never ambiguous about the corresponding value, while str() might be. For example:
"1" '1' 1 1 str("1") '1' str(1) '1'
That desire for an unambiguous repr for each value is why CPython defaults to using "<TYPE at ADDRESS>" Having repr support eval is certainly nice when practical, but it's far from a requirement. Even the desire for a unique repr-per-value isn't a guarantee, since some types *do* impose a size limit.
I don't think the # of pages it outputs should really matter, if the thing you are printing really is that big. It won't be much bigger than printing big lists or dicts, and we happily let those cause the terminal to scroll for minutes at a time if we accidentally print them. The default behavior (e.g. when you print() it or string-interpolate it) would still give you something short and nice to look at. Presumably when someone called repr() instead of str(), he was hoping for some sort of eval()-able code snippet.
In this particular case, I'm also inclined to favour the approach of using ast.dump as the repr for AST nodes. Call it +0. Adding support for depth limiting and peer node limiting to ast.dump (with missing nodes replaced with "...") would also be neat. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
On Wed, May 1, 2013 at 6:51 AM, Nick Coghlan <ncoghlan@gmail.com> wrote:
In this particular case, I'm also inclined to favour the approach of using ast.dump as the repr for AST nodes. Call it +0.
Adding support for depth limiting and peer node limiting to ast.dump (with missing nodes replaced with "...") would also be neat.
https://bitbucket.org/techtonik/astdump/src/ed73edbdccb5fd9d4255d7ed64f45b69... Something like this? -- anatoly t.
participants (5)
-
anatoly techtonik -
Guido van Rossum -
Haoyi Li -
Nick Coghlan -
Steven D'Aprano