On 03/26/2018 10:35 AM, Roberto Martínez wrote:

Hi,

sometimes I need to use contextlib.close but over methods with a different name, for example stop(), halt(), etc. For those cases I have to write my own contextlib.close specialized version with a hard-coded method name.

I think adding a "method" argument to contextlib.close can be very useful:

@contextmanager def closing(thing, method="close"): try: yield thing finally: getattr(thing, method)()

+1

On 26 March 2018 at 18:35, Roberto Martínez <robertomartinezp@gmail.com> wrote:

@contextmanager def calling(fn, *args, **kwargs): try: yield finally: fn(*args, **kwargs)

I'd be more amenable to a proposal along these lines (rather than adding a parameter to closing), as it more closely resembles the way that contextlib.ExitStack.callback already works: with contextlib.ExitStack() as stack: stack.callback(fn, *args, **kwds) ... In cases where you just want to call a single operation and don't need the extra complexity and overhead of the dynamic stack, then it would be nice to be able to instead write: with contextlib.callback(fn, *args, **kwds): ... Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia

On 03/26/2018 10:35 AM, Roberto Martínez wrote:

Hi,

sometimes I need to use contextlib.close but over methods with a different name, for example stop(), halt(), etc. For those cases I have to write my own contextlib.close specialized version with a hard-coded method name.

I think adding a "method" argument to contextlib.close can be very useful:

@contextmanager def closing(thing, method="close"): try: yield thing finally: getattr(thing, method)()

+1

On 26 March 2018 at 18:35, Roberto Martínez <robertomartinezp@gmail.com> wrote:

@contextmanager def calling(fn, *args, **kwargs): try: yield finally: fn(*args, **kwargs)

I'd be more amenable to a proposal along these lines (rather than adding a parameter to closing), as it more closely resembles the way that contextlib.ExitStack.callback already works: with contextlib.ExitStack() as stack: stack.callback(fn, *args, **kwds) ... In cases where you just want to call a single operation and don't need the extra complexity and overhead of the dynamic stack, then it would be nice to be able to instead write: with contextlib.callback(fn, *args, **kwds): ... Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia