Attendees: Benedikt, Mark
Agenda:
Review last week's action items:
everyone should look into the finalizer issues if they can
PythonException finalizer update
Notes:
No quorum, meeting canceled
Action Items:
Mark will check if dev work on existing Unity PRs is still in progress (if not, please comment on the PR when we expect work to resume)
The meeting notes google doc is here <https://docs.google.com/document/d/1rJVU84B_dgx58-_EopjRtOJVFAI2WfHJYV0n7uE…>. Feel free to correct or add additional information.
The next meeting will be held on Thursday, April 8 at 12pm EST (click for your time zone) <https://www.google.com/search?q=12:00+pm+EST>.
Mark Visser
Senior Dev Manager, M&E
Unity Technologies - www.unity3d.com <http://www.unity3d.com/>
Attendees: Felix, Benoit, Mark
Agenda:
Review last week's action items:
Amos will check if _GC_Calloc can be replaced with public function
Felix will continue working on PythonException finalizer
Notes:
Benedikt agrees it's a good idea to get rid of _GC_Calloc, need to be mindful that allocation works with domain reload
Technical discussion on debugging
Current state of tests is that we have pytest and NUnit tests
can run pytest through NUnit but not the inverse
should we keep both?
domain reload tests are separate (Re-enable the domain reload tests <https://github.com/pythonnet/pythonnet/pull/1404>)
could trip up devs if they don't know to run the reload tests
same situation right now with pytests & NUnit tests - need to run both locally
document? make available via a single front-end?
ideally running either pytest or NUnit tests runs all interesting tests
most code is in C#, maybe dotnet test should run all tests, not pytest
still nice to run pytest, allows us to write pytests in a meaningful way
pytests are a bit hacky as they need to build the Python tests DLL
ideal to run all tests through dotnet test - big project though
create a bridge to run pytests via NUnit?
Benedikt needs to think more on how to solve this
current setup is fine for now (keep as separate steps)
Modernize import hook <https://github.com/pythonnet/pythonnet/pull/1369>
import hook as python code has implications
can we embed it instead of having it as a .py file?
Benedikt has no major changes planned
going through PRs to get pythonnet into a stable state
dealing with finalizer issues
once main performance issues, finalizer fixes & import hook is merged we'll be ready for 3.0
the work Victor has started on reworking older components is good
look at obsoleting unsafe interfaces before major release
What does Unity need?
import hook is the last thing
we'd like to ship with an official 3.0 (currently shipping a git hash build)
timeline for that is fall 2021
Action items:
everyone should look into the finalizer issues if they can
The meeting notes google doc is here <https://docs.google.com/document/d/1rJVU84B_dgx58-_EopjRtOJVFAI2WfHJYV0n7uE…>. Feel free to correct or add additional information.
The next meeting will be held on Thursday, March 25 at 12pm EST (click for your time zone) <https://www.google.com/search?q=12:00+pm+EST>.
Mark Visser
Senior Dev Manager, M&E
Unity Technologies - www.unity3d.com <http://www.unity3d.com/>
