Working group notes for February 11
Attendees: Victor, Benedikt, Mark, Felix, Amos Agenda: Review last week's action items: Victor: fix merge conflict and merge PythonDLL PR Victor: create issue for domain reload when .NET objects point to PythonException and/or PyObject Benedikt will check if he can restore perf tests using wheel of 2.5.1 Notes: PythonDLL PR was merged domain reload when .NET objects point to PythonException and/or PyObject Felix found a problem, will create PR to fix PyValue wasn't reference counted PythonDLL work Python usually requires setting PYTHON_HOME - maybe we should try to discover DLL location from PYTHON_HOME instead of starting from the DLL location? PYTHON_HOME doesn't work very well for system environment maybe should try to discover PYTHON_HOME from DLL path instead? need to have both Benedikt will take a look at different OSes and see what could work CLR Loader PR The failures are due to Finalize call from Python on process shutdown, which previously was not there Calling Finalize is correct, but exposes preexisting bugs that now cause CI to fail can we ignore the CI failures and fix them as a separate issue? yes Benedikt will move code fixing reference counting (and other changes unrelated to Finalize) and enabling Finalize to a new branch and land CLR loader we'll treat the surfaced Finalize issues separately Felix will need to rebase his PR CI will continue to non-deterministically fail in the interim weakref support PR need to fix some bugs to pass CI Action items: Felix will create PR to likely fix Domain reload crashes when .NET object points to PythonException <https://github.com/pythonnet/pythonnet/issues/1371> Benedikt will look into automatically setting PYTHON_HOME and/or inferring location of Python DLL Benedikt will comment on the CLR Loader regarding Finalize call from Python on process shutdown and merge the PR The meeting notes google doc is here <https://docs.google.com/document/d/1rJVU84B_dgx58-_EopjRtOJVFAI2WfHJYV0n7uE1Oak/edit#>. Feel free to correct or add additional information. The next meeting will be held on Thursday, February 25 at 12pm EST (click for your time zone) <https://www.google.com/search?q=12:00+pm+EST>. Mark Visser Senior Dev Manager, M&E Unity Technologies - www.unity3d.com <http://www.unity3d.com/>
participants (1)
-
Mark Visser