Hi Stefan,<br><br><div class="gmail_quote">2009/11/2 Stéfan van der Walt <span dir="ltr">&lt;<a href="mailto:stefan@sun.ac.za">stefan@sun.ac.za</a>&gt;</span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Hi all,<br>
<br>
Please review the Shortest Path functionality implemented in branch &#39;spath&#39; of<br>
<br>
<a href="http://github.com/stefanv/scikits.image" target="_blank">http://github.com/stefanv/scikits.image</a><br></blockquote><div><br>Looks good, both the shortest path algorithm and the Cython build improvements.<br><br>
About the build first, I had to run the setup.py in analysis separately, it wasn&#39;t picked up by the main setup.py. I do not have Cython installed.<br><br>Some questions / points to think about for shortest path:<br><br>
- why only left-to-right through the image? it would be easy to have an axis keyword and then transpose the image if necessary.<br>- module name. &quot;analysis&quot; is quite generic, if that is where most algorithms end up it will be a very large module after a while. maybe that is okay, i&#39;m not sure.<br>
- docstring is rather incomplete: needs Returns, References, Examples, Notes: synonym=Dijkstra&#39;s algorithm<br>- for the test, why is path [0, 0, 1] instead of either [1, 0 ,1] or [0, 1, 0]? I would expect path to contain either indices or values of the followed path. <br>
<br>- and some questions motivated by my lack of knowledge of Cython: <br>* can you write r_bracket_min = max(r - 1, 0) and leave out the if &lt; 0 check afterward?<br>* what is the overhead (if any) of a triple for loop in Cython? I don&#39;t see an obvious way to vectorize things, but if it&#39;s possible (even partially), would that help?<br>
<br>Cheers,<br>Ralf<br><br></div></div>