
Nov. 6, 2010
1:48 a.m.
2010/11/5 Stéfan van der Walt <stefan@sun.ac.za>:
Please review the proposed plugin hook for an Image Collection reader:
Can you explain why you set up the tests like that? It seems the test is split over two files, with this change: +def imread_collection(x, conserve_memory=True): + assert conserve_memory == False + assert x == '*.png' relying on a call from another file with the expected arguments. This will be confusing I think. The rest looks good to me. Cheers, Ralf