2009/10/21 Ralf Gommers firstname.lastname@example.org:
The code I have so far lives here: http://github.com/rgommers/scikits.image/tree/color
Thanks for cleaning up the colour conversion routines! Here are some review comments:
- Add this contribution to CONTRIBUTORS.txt - Do not check types explicitly against ndarray. A safer route is to use "asanyarray". - "float32" is not a valid dtype descriptor -- use np.float32 instead - Question: why are there NaN's in the output?
A question that pertains to the scikit as a whole: what do we assume the limits of images to be? I think a common convention is 0-255 for type uint8 and 0-1 for type float. These need to be handled in all functions, and we may soon see patterns emerging that can be captured in standard utility functions.