OK, I would commen my code, and try to profile the skimage's code. then start a issue on github.
I once tried to contribute to scikit-image. But give up, for I am averse to write cython. I prefer writting in pure C, and importting with ctypes, or writting pure python with numba (JNI recommend to me). So I agree with using numba to extend scikit-image(we discussed before).
And I had wrote or improve some other function may be usful. I improved the medal axis, watershed, h_maxma/minma, and writed a ridge algrism(extract the ridge or river valley), and we can use them in imagepy interactively. I will attach some snapshot, please have a look.
(I had wrapped many functions of scipy.ndimage and skimage in imagepy, and have built some user base in my country (China), they will feed back some questions to me, I think it's useful to imagepy and skimage)
----- 原始邮件 -----
发件人:Stefan van der Walt <stefanv@berkeley.edu>
收件人:scikit-image@python.org
主题:Re: [scikit-image] 转发:some question about_h_minma_(need_a_paremeter,_and_can_run_faster)
日期:2017年09月10日 11点29分
Hi, YXDragon
So I wrote h_minma/maxma and watershed myself (as a sub package of my project imagepy). My watershed now only support 2D, But the h_minma now is OK, works on nd. I had test one image:
scikit-image's h_minma runs in 15s, and mine runs in 0.3s, 45times.
I tested on my machine and can confirm the slowness. Would you be willing to help profile the code, to find out why it is so slow?
Best regards
Stéfan
_______________________________________________
scikit-image mailing list
scikit-image@python.org
https://mail.python.org/mailman/listinfo/scikit-image