2009/11/3 Stéfan van der Walt <stefan@sun.ac.za>

Hi Ralf

2009/11/3 Ralf Gommers <ralf.gommers@googlemail.com>:
> About the build first, I had to run the setup.py in analysis separately, it
> wasn't picked up by the main setup.py. I do not have Cython installed.

I think I fixed that this morning, please confirm.

Ah yes, works now. I tested your spath branch and now see you made more improvements in master. Merging before review eh:)


> - why only left-to-right through the image? it would be easy to have an axis
> keyword and then transpose the image if necessary.

I guess you can manipulate the data any way you like before sending it
in.  This is just the way most algorithms, such as Viterbi, are
defined.

Sure.
 
> - module name. "analysis" is quite generic, if that is where most algorithms
> end up it will be a very large module after a while. maybe that is okay, i'm
> not sure.

I'd be glad for some suggestions on a different name -- I wasn't quite
sure myself.

"graph" maybe? or "tree"?
 

> - for the test, why is path [0, 0, 1] instead of either [1, 0 ,1] or [0, 1,
> 0]? I would expect path to contain either indices or values of the followed
> path.

It contains the row coordinate for each column.  Using that
information, constructing the values along that path would be easy:

x[path, :] -> values

If there are many equivalent paths, the first is picked.

Ah yes, the docstring I looked at was incomplete so I was confused about the definition of cost. Makes perfect sense now.

Cheers,
Ralf