Sphinx docs improvements
Hi all. I wanted to get some feedback regarding some changes to the building of the docs. Juan asked myself and a colleague Vinicius Cerutti to look after a feature request (posted on Zulip) for a warning banner when a user is not on the docs for the most recent release. A nice solution for this would be https://goerz.github.io/docs_versions_menu/v0.4.1/. This builds on the efforts of doctr, a tool that, while similar to readthedocs, provides a lot of flexibility in the build of the documentation: https://drdoctr.github.io/. The sphinx theme (alabaster) used by doctr is quite similar to the current theme used for the scikit-image docs so there won't be too much of a change to the aesthetics of the site. How do people feel about such a change? The alternative would be to add a custom javascript snippet to implement this... that would be an easy enough quick fix if people aren't fans of such a docs-infrastructure migration, Thanks, John -- -- *John Lee* Software Engineer *Quansight* | Your Data Experts w: www.quansight.com <http://www.openteams.com/> e: john.lee@quansight.com <ashley@openteams.com> <https://www.linkedin.com/company/quansight/> <https://twitter.com/quansightai>
To me the infrastructure change is *a little* concerning, but could work. It's all in the details! 😊 Is the sphinx theme not configurable anyway? At any rate I think there will be a push shortly to adopt the PyData theme. Let's see what others have to say... Thanks for taking the initiative John! Juan. On Tue, 15 Jun 2021, at 5:03 AM, John Lee wrote:
Hi all.
I wanted to get some feedback regarding some changes to the building of the docs. Juan asked myself and a colleague Vinicius Cerutti to look after a feature request (posted on Zulip) for a warning banner when a user is not on the docs for the most recent release. A nice solution for this would be https://goerz.github.io/docs_versions_menu/v0.4.1/. This builds on the efforts of doctr, a tool that, while similar to readthedocs, provides a lot of flexibility in the build of the documentation: https://drdoctr.github.io/. The sphinx theme (alabaster) used by doctr is quite similar to the current theme used for the scikit-image docs so there won't be too much of a change to the aesthetics of the site. How do people feel about such a change? The alternative would be to add a custom javascript snippet to implement this... that would be an easy enough quick fix if people aren't fans of such a docs-infrastructure migration,
Thanks,
John
-- --
*John Lee* Software Engineer
*Quansight* | Your Data Experts
w: www.quansight.com <http://www.openteams.com/> e: john.lee@quansight.com <mailto:ashley@openteams.com> <https://www.linkedin.com/company/quansight/> <https://twitter.com/quansightai>
Hi John, On Tue, Jun 15, 2021, at 03:03, John Lee wrote:
I wanted to get some feedback regarding some changes to the building of the docs. Juan asked myself and a colleague Vinicius Cerutti to look after a feature request (posted on Zulip) for a warning banner when a user is not on the docs for the most recent release. A nice solution for this would be https://goerz.github.io/docs_versions_menu/v0.4.1/. This builds on the efforts of doctr, a tool that, while similar to readthedocs, provides a lot of flexibility in the build of the documentation: https://drdoctr.github.io/. The sphinx theme (alabaster) used by doctr is quite similar to the current theme used for the scikit-image docs so there won't be too much of a change to the aesthetics of the site. How do people feel about such a change? The alternative would be to add a custom javascript snippet to implement this... that would be an easy enough quick fix if people aren't fans of such a docs-infrastructure migration,
Thank you for your help with the scikit-image infrastructure! This work is so important, and way overdue. In terms of themes, we should migrate to the pydata-sphinx theme as soon as possible. The community is standardizing on it, and that is where new features will be developed. I know, e.g., that they have a grant proposal submitted that would fund development on, among other things, a versioning bar. As you mention, it's already trivial to implement it in the simplest way possible: https://networkx.org/documentation/latest/ Ideally, the version bar should find "nearest" pagest in older versions—which is what the PyData Sphinx theme team will build. I.t.o. builders: I am opposed to using anything other than GitHub Pages steps (or similar) to build and upload the documentation to GitHub. We used some of these tools before, and the magic behind which they hide the build steps is a great hindrance for new developers trying to understand the overarching process. Thanks again for your work on this! Best regards, Stéfan
Sorry for the delayed reply. Some personal email list subscription confusion.
Is the sphinx theme not configurable anyway?
It is but I couldn't spot a banner version option (readthedocs sphinx theme has this built in). Without that, I think modifying the theme itself or the javascript snippet are the quick solutions. The latter can be done but the migration to the pydata theme renders the work needless (unless it takes them a while to implement...).
This work is so important, and way overdue.
Thanks. It's great to get to contribute to such a neat project.
we should migrate to the pydata-sphinx theme as soon as possible
Noted. That's the path forward then. We'll submit a PR.
the magic behind which they hide the build steps is a great hindrance for new developers trying to understand the overarching process
Sounds good. We might consider some degree of automation of the current workflow to relieve the core devs of some manual tasks but it sounds far down the list of priorities.
On Mon, Jun 21, 2021, at 03:51, john lee wrote:
Sounds good. We might consider some degree of automation of the current workflow to relieve the core devs of some manual tasks but it sounds far down the list of priorities.
I think automation is important, but it would be interesting to see how far we can get using GitHub actions. Stéfan
participants (4)
-
John Lee
-
john lee
-
Juan Nunez-Iglesias
-
Stefan van der Walt