On Fri, Dec 30, 2011 at 8:20 AM, Nadav Horesh firstname.lastname@example.org wrote:
Remarks for the convolution subpackage:
- The __init__.py should be probably changed to
from ext import pyconvolve as convolve
- The test_convolution.py file is very instructive. It should be polished a
bit. I think it would be worthwhile to add also scipy.signal.sepfir2d and cv2.sepFilter2D to the test.
- I found the convolve speed in par with cv.convolve2d (it can be slower or
faster depending on the kernel)
That's great. Do you know how we can reliably make this code compile on all supported platforms?