Robert's Edge Detection. Part of [GsoC13]
Hi, It was suggested earlier that I submit a patch to get familiar with the codebase before applying for GsoC. So, I implemented Robert's Edge Detection algorithm (http://homepages.inf.ed.ac.uk/rbf/HIPR2/roberts.htm). I created an issue for this on github and I have the implementation in my git repo. Should I submit a pull request for this? Regards, Umesh
On Sat, Apr 20, 2013 at 8:22 AM, Umesh Sharma
Hi,
It was suggested earlier that I submit a patch to get familiar with the codebase before applying for GsoC. So, I implemented Robert's Edge Detection algorithm (http://homepages.inf.ed.ac.uk/rbf/HIPR2/roberts.htm). I created an issue for this on github and I have the implementation in my git repo. Should I submit a pull request for this?
Hi Umesh,
Yes, just go ahead and submit a PR. Best, -Tony
Hi, I have updated the changes suggested by Tony S Yu , in the implementation of Robert's Edge Detection algorithm Regards , Umesh
Hi, I have changes that Tony S Yu suggested and i have also added three test in test_edge.py . I have added three tests one for all zero one for one diagonal and one for other diagonal . Is no of tests are enough or i need to write more ?? Regards Umesh
Hi Tony , Can you tell me status of the Robert's edge detection part ? Do is it okay or there are other changes left ? Thanks, Umesh
On Wed, Apr 24, 2013 at 11:41 PM, Umesh Sharma
Hi Tony ,
Can you tell me status of the Robert's edge detection part ? Do is it okay or there are other changes left ?
I think the Roberts edge detection part looks good, but you should probably move the Frei-Chen functions to a separate branch if you want the PR merged sooner. The new functions will require some more rounds of review before merging. Best, -Tony
Thanks Tony , I have removed that part from my commit , now the latest commit contains the robert's edge detector .... Regards , Umesh
On Thu, Apr 25, 2013 at 8:14 AM, Umesh Sharma
Thanks Tony , I have removed that part from my commit , now the latest commit contains the robert's edge detector ....
Hi Umesh, Thanks again for the PR. I just wanted to clarify that I was suggesting that the Frei-Chen functions be moved to a new PR---not removed completely. That said, it would probably be best to wait until some upcoming changes to the edge filters are merged, so there aren't too many merge conflicts. I'm thinking specifically of this PR: https://github.com/scikit-image/scikit-image/pull/536 Best, -Tony
participants (2)
-
Tony Yu -
Umesh Sharma