Re: Contribution: circles and hough transform

Hi, Any hopes of this making it into the 0.8 release? Regards, /Anders On 3 feb 2013, at 20:11, Stéfan van der Walt <stefan@sun.ac.za> wrote:
Hi François
Yes, you may rely on Cython, so no need to code a pure Python version.
Renaming the function as suggested would break backward compatibility, so I suggest adding hough_line as an alias, and deprecating hough over two releases.
Regards Stéfan
On Feb 3, 2013 9:04 PM, "François" <francois.boulogne@gmail.com> wrote: Hi,
I have written the hough transform for circles in python and have a good basis for peak detection.
I have few questions: 1/ in skimage/transform/hough_transform.py Cython version of hough() is imported like this (below the python version) 59 # try to import and use the faster Cython version if it exists 60 try: 61 from ._hough_transform import _hough 62 except ImportError: 63 pass
Should I do the same for hough_circle()? or just implement the cython version? I don't see why cython would not be available...
2/ For disambiguation, I suggest to rename hough to hough_line(). The same for peak detection. Any comment on that?
Cheers, François.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

On Mon, Feb 18, 2013 at 12:48 PM, Anders Klint <anders.c.klint@gmail.com> wrote:
Any hopes of this making it into the 0.8 release?
Currently, that PR still lacks a gallery example, and there are some outstanding comments to be addressed (minor). If that is addressed, we can include it in the release. Stéfan
participants (2)
-
Anders Klint
-
Stéfan van der Walt