Re: [scikit-image] How to move pull requests forward (devs, please read)
14 Apr
2017
14 Apr
'17
4:19 p.m.
On Thu, Apr 13, 2017, at 21:30, Vighnesh Birodkar wrote:
But apart from this the PR does what the algorithm it implements correctly. Can we merge such a PR in master and keep it as a private unexposed function while raising an issue to address it's shortcomings ? The function can de decorated to exclude it from the main docs and maybe raise a warning when invoked. I believe the flaws I mentioned can be taken up by someone else in the community. Like a user might contribute documentation or a newcomer might do the refactoring. Then later down the line core Devs can agree and make the function public.
What you're describing above sounds a lot like skimage.future. Experimental, but with the intent to mature for full inclusion. Stéfan
2806
Age (days ago)
2806
Last active (days ago)
0 comments
1 participants
participants (1)
-
Stefan van der Walt