Re: Contribution: circles and hough transform
Le mercredi 9 janvier 2013 17:05:53 UTC+1, Stefan van der Walt a écrit :
Both patches would be very welcome! Let us know if you need any help getting started.
Thank. I discovered in master circle_perimeter(). This is actually the bresenham method. This PR is for Andres method. https://github.com/scikit-image/scikit-image/pull/410 Since bresenham in already in master, I'm working on the hough transform. :) François.
Hi, I have written the hough transform for circles in python and have a good basis for peak detection. I have few questions: 1/ in skimage/transform/hough_transform.py Cython version of hough() is imported like this (below the python version) 59 # try to import and use the faster Cython version if it exists 60 try: 61 from ._hough_transform import _hough 62 except ImportError: 63 pass Should I do the same for hough_circle()? or just implement the cython version? I don't see why cython would not be available... 2/ For disambiguation, I suggest to rename hough to hough_line(). The same for peak detection. Any comment on that? Cheers, François. <https://fr.wiktionary.org/wiki/disambiguation#en><https://fr.wiktionary.org/wiki/disambiguation#en>
Hi François Yes, you may rely on Cython, so no need to code a pure Python version. Renaming the function as suggested would break backward compatibility, so I suggest adding hough_line as an alias, and deprecating hough over two releases. Regards Stéfan On Feb 3, 2013 9:04 PM, "François" <francois.boulogne@gmail.com> wrote:
Hi,
I have written the hough transform for circles in python and have a good basis for peak detection.
I have few questions: 1/ in skimage/transform/hough_transform.py Cython version of hough() is imported like this (below the python version) 59 # try to import and use the faster Cython version if it exists 60 try: 61 from ._hough_transform import _hough 62 except ImportError: 63 pass
Should I do the same for hough_circle()? or just implement the cython version? I don't see why cython would not be available...
2/ For disambiguation, I suggest to rename hough to hough_line(). The same for peak detection. Any comment on that?
Cheers, François. <https://fr.wiktionary.org/wiki/disambiguation#en><https://fr.wiktionary.org/wiki/disambiguation#en>
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
participants (2)
-
François -
Stéfan van der Walt