Please review the proposed plugin hook for an Image Collection reader: https://github.com/stefanv/scikits.image/compare/master...imagecollection Having a way to easily load and manipulate a whole collection of images would be great! Think for example, of how easily SciVi could become a usable image (gallery) viewer. Regards Stéfan
Scivi's gonna get a new-and-improved frontend and features when I get some time ;) 2010/11/5 Stéfan van der Walt <stefan@sun.ac.za>
Please review the proposed plugin hook for an Image Collection reader:
https://github.com/stefanv/scikits.image/compare/master...imagecollection
Having a way to easily load and manipulate a whole collection of images would be great! Think for example, of how easily SciVi could become a usable image (gallery) viewer.
Regards Stéfan
This is a good idea, and image sequences will definitely be useful for movies. However, I'm not sure that scivi should be a gwenview-like "gallery" image viewer, but rather a scientific visualization toolkit.. I'd definitely want movie sequences to be handled (as a sequence of image files, not necessarily .avi, but we could have script to convert from/to ), but I don't really see how the "gallery of images" feature might be useful? On the contrary, something that might be useful is this: often when doing experiments, you try lots of parameters on the same image, and you have a metric for the result. Say for instance, that you have 2 parameters taking values in [0,1]² and you have a metric taking values in [0,1], then you could sample points in the grid, use your algorithm with the sampled parameters, and show the grid as dots (position: parameters, color/size is metric) and when clicking on the dot, it might show the corresponding filtered image. This might prove nice for algorithm exploration
Hi St�fan, I'm a bit confused about this being "proposed", since we were using it at the SciPy sprints(?). Not that me being confused matters a lot when I haven't been active on the project since, but just curious :-). Thanks! James. PS. I notice you haven't pulled in my FITS plugin yet. Were you still waiting on me doing something (I believe I replied to a message asking about merging it a while ago, but maybe something is still missing)?
Please review the proposed plugin hook for an Image Collection reader:
https://github.com/stefanv/scikits.image/compare/master...imagecollection
Having a way to easily load and manipulate a whole collection of images would be great! Think for example, of how easily SciVi could become a usable image (gallery) viewer.
Regards St�fan
Hi James On Fri, Nov 5, 2010 at 5:47 PM, James Turner <jturner@gemini.edu> wrote:
I'm a bit confused about this being "proposed", since we were using it at the SciPy sprints(?). Not that me being confused matters a lot when I haven't been active on the project since, but just curious :-).
Your confusion is fully warranted :) Like you mentioned, I haven't merged your FITS plugin yet, and this is a building block in that direction. I'm just making sure everyone is happy with the proposed changes--also those who weren't at the sprint. Sorry for the long day; I'm playing catch-up now! Cheers Stéfan
Hi James On Fri, Nov 5, 2010 at 5:47 PM, James Turner <jturner@gemini.edu> wrote:
PS. I notice you haven't pulled in my FITS plugin yet. Were you still waiting on me doing something (I believe I replied to a message asking about merging it a while ago, but maybe something is still missing)?
I just tested your FITS plugin; works beautifully. It's now merged into master. Cheers Stéfan
2010/11/5 Stéfan van der Walt <stefan@sun.ac.za>:
Please review the proposed plugin hook for an Image Collection reader:
Can you explain why you set up the tests like that? It seems the test is split over two files, with this change: +def imread_collection(x, conserve_memory=True): + assert conserve_memory == False + assert x == '*.png' relying on a call from another file with the expected arguments. This will be confusing I think. The rest looks good to me. Cheers, Ralf
Hi Ralph On Sat, Nov 6, 2010 at 3:48 AM, Ralf Gommers <ralf.gommers@googlemail.com> wrote:
Can you explain why you set up the tests like that? It seems the test is split over two files, with this change: +def imread_collection(x, conserve_memory=True): + assert conserve_memory == False + assert x == '*.png' relying on a call from another file with the expected arguments. This will be confusing I think.
I wasn't sure how to test the plugin otherwise, but I'm open for ideas! Cheers Stéfan
2010/11/7 Stéfan van der Walt <stefan@sun.ac.za>:
Hi Ralph
On Sat, Nov 6, 2010 at 3:48 AM, Ralf Gommers <ralf.gommers@googlemail.com> wrote:
Can you explain why you set up the tests like that? It seems the test is split over two files, with this change: +def imread_collection(x, conserve_memory=True): + assert conserve_memory == False + assert x == '*.png' relying on a call from another file with the expected arguments. This will be confusing I think.
I wasn't sure how to test the plugin otherwise, but I'm open for ideas!
Now you're asking me to think:) It seems to be a reasonable solution actually, maybe just a comment in _plugins/test_plugin.py that it's called from io/tests/test_plugin.py would be useful. Cheers, Ralf
On Mon, Nov 8, 2010 at 5:24 PM, Ralf Gommers <ralf.gommers@googlemail.com> wrote:
Now you're asking me to think:) It seems to be a reasonable solution actually, maybe just a comment in _plugins/test_plugin.py that it's called from io/tests/test_plugin.py would be useful.
All-right, done! Stéfan
participants (5)
-
Chris Colbert -
James Turner -
Maël Primet -
Ralf Gommers -
Stéfan van der Walt