Yes, the code in the package is a bit over-complicated :-) It's probably easier to re-implement the rather simple functionality... maybe I'll have some spare time on a flight :-) The question is where this code should go. I don't think it's a good idea to place those "artistic" filters directly into skimage.filter, maybe better skimage.filter.effects... Am 06.01.2014 um 18:48 schrieb Ronnie Ghose <ronnie.ghose@gmail.com>:

the code is actually very simple - it shouldn't be too much work. quite a lot of random boilerplate though

On Mon, Jan 6, 2014 at 6:47 PM, Juan Nunez-Iglesias <jni.soma@gmail.com> wrote: You should know as well as anybody that reviewing the PR will be a lot of work! =) Again, if someone else volunteers, I'm happy for it to go ahead. But certainly if we invite the PR, it should be reviewed quickly. We don't want to invite someone and then have the PR languish in review.

On Tue, Jan 7, 2014 at 1:14 AM, Johannes Schönberger <jsch@demuc.de> wrote: Yes, I definitely agree on all your points, but we could ask the author of the package if she/he is willing to do it?

Johannes

Am 05.01.2014 um 21:47 schrieb Ronnie Ghose <ronnie.ghose@gmail.com>:

...

+ To Juan's Idea.. they look nice ... but I can't see intellectual applications? Maybe have a reference to them or the like, I don't know if we want to spend time maintaining them necessarily

On Sun, Jan 5, 2014 at 9:45 PM, Juan Nunez-Iglesias <jni.soma@gmail.com> wrote: I'm ambivalent. They are cool and would be nice for publicity, but let's not forget that it's scikit-image, and these filters have questionable scientific use (at least that I can think of — I've been shown more than once to lack imagination! =). In addition, the object-based implementation wouldn't fit very well with skimage's more functional interface.

I wouldn't be opposed to including them but I also would not want to spend my time on them.

Juan.

On Mon, Jan 6, 2014 at 12:11 PM, Johannes Schönberger <jsch@demuc.de> wrote: Hi everyone,

Interesting and those filters could be incorporated into scikit-image in my opinion:

http://jason2506.github.io/imfilter/

What do others think?

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.

-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.