On 2/12/2012 2:36 AM, Emmanuelle Gouillart wrote:

On Sat, Feb 11, 2012 at 05:07:21PM -0500, Tony Yu wrote:

...

I'd be in favor of supporting numpy 1.5. Just note that the `convert`
function uses `np.promote_types`, which is also new to numpy 1.6.
-Tony

Thanks Tony, I figured this out when running the tests :-). So if we want to support numpy 1.5, we'll have to write a conversion table to emulate what np.promote_types does, is that correct?

Emmanuelle

Note that the original rewrite of the dtype._convert function had it's own inline implementation of dtype promotion, e.g. https://github.com/cgohlke/scikits-image/commit/038db9d1abb684e22656af4a954c94109ac0f94f#L0R74.

Christoph