I note this and hopefully I will be able to submit a PR over the next days.
On Nov 20, 2014, at 5:21 AM, Stéfan van der Walt <stefan@sun.ac.za> wrote:
Nice suggestion, Tony.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
What’s the desired path here? 1) `sobel_h`/`sobel_v` (or `sobel_x`/`sobel_y`; in this case, it might make sense to match x/y with the gradient direction rather than the edge direction) 2) deprecation warning kwarg? I am voting for option 1.
On Nov 20, 2014, at 9:10 PM, Stefan van der Walt <stefan@sun.ac.za> wrote:
Thanks very much, @ahojnnes
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Apologies for my curt previous reply--I thought I was responding to a ticket on GitHub! On 2014-11-27 15:41:27, Johannes Schoenberger <jsch@demuc.de> wrote:
What’s the desired path here?
1) `sobel_h`/`sobel_v` (or `sobel_x`/`sobel_y`; in this case, it might make sense to match x/y with the gradient direction rather than the edge direction)
I'd be careful of using `x` and `y`, given that we're trying to standardize on a different convention. I would expect `sobel_h` to highlight horizontal edges (since `sobel` is known as an edge detector). Stéfan
Ok. Then option 1) but with h and v.
On Nov 27, 2014, at 9:53 AM, Stefan van der Walt <stefan@sun.ac.za> wrote:
Apologies for my curt previous reply--I thought I was responding to a ticket on GitHub!
On 2014-11-27 15:41:27, Johannes Schoenberger <jsch@demuc.de> wrote: What’s the desired path here?
1) `sobel_h`/`sobel_v` (or `sobel_x`/`sobel_y`; in this case, it might make sense to match x/y with the gradient direction rather than the edge direction)
I'd be careful of using `x` and `y`, given that we're trying to standardize on a different convention. I would expect `sobel_h` to highlight horizontal edges (since `sobel` is known as an edge detector).
Stéfan
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
participants (3)
-
Johannes Schoenberger
-
Johannes Schönberger
-
Stefan van der Walt