On Wed, May 30, 2012 at 1:25 AM, Stéfan van der Walt <stefan@sun.ac.za>wrote:
On Tue, May 29, 2012 at 8:18 PM, Tony Yu <tsyu80@gmail.com> wrote:
Hmm, I don't think so. It looks like `skimage.io._plugins.plugin.call` looks in `skimage.io.plugin_store`. But `plugin_store` is populated by the first installed plugin in a list of preferred plugins. Whatever matches, takes over all io operations (more or less). If that plugin doesn't provide `imread_collection`, then that entry in `plugin_store` remains empty. (In other words, after accepting a plugin, there's no additional check afterwards to fill in the functions not provided by that plugin.)
That's not the way it should behave; we should fix it to transparently fall back to whatever is available.
I've addressed this specific issue in PR 196<https://github.com/scikits-image/scikits-image/pull/196>. Note: It still doesn't fix the original test error (but if the tifffile plugin gained an `imread_collection` function, then that would fix it).
Is there any reason why there's no default `imread_collection` which just passes arguments to `ImageCollection`?
No, that would probably make sense. And I think ImageCollection uses the plugin version of imread.
Yup: any plugin that provides `imread` should be able to provide an `imread_collection`. I can take care of this at a later date. (It'd be great if someone beat me to it, though ;) -Tony
participants (1)
-
Tony Yu