OK, unittest added: https://github.com/scikit-image/scikit-image/pull/508 Also, BTW, I get the below test failure when I have matplotlib but no PIL installed. I think test_imread_url or the test right before it must be making some incorrect assumptions. (If I re-run the tests after this failure, then also all of the tifffile tests fail, so it seems that some test isn't doing proper teardown of the image loading plugins?) Zach ERROR: test_io.test_imread_url ---------------------------------------------------------------------- Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/case.py", line 197, in runTest self.test(*self.arg) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/scikit_image-0.9dev-py2.7-macosx-10.6-intel.egg/skimage/io/tests/test_io.py", line 27, in test_imread_url image = io.imread(image_url) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/scikit_image-0.9dev-py2.7-macosx-10.6-intel.egg/skimage/io/_io.py", line 136, in imread img = call_plugin('imread', f.name, plugin=plugin, **plugin_args) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/scikit_image-0.9dev-py2.7-macosx-10.6-intel.egg/skimage/io/_plugins/plugin.py", line 100, in call return func(*args, **kwargs) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/matplotlib/pyplot.py", line 1750, in imread return _imread(*args, **kwargs) File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/matplotlib/image.py", line 1193, in imread raise ValueError('Only know how to handle extensions: %s; with PIL installed matplotlib can handle more images' % handlers.keys()) ValueError: Only know how to handle extensions: ['png']; with PIL installed matplotlib can handle more images On Apr 18, 2013, at 8:47 AM, Juan Nunez-Iglesias wrote:
I think Zach knows better than I what the source of the error was, so he should probably handle it. ;)
On Thu, Apr 18, 2013 at 12:52 PM, Stéfan van der Walt <stefan@sun.ac.za> wrote: Hi Juan
On Apr 18, 2013 2:35 AM, "Juan Nunez-Iglesias" <jni.soma@gmail.com> wrote:
Yep, I've confirmed that your PR solved the problem for me! So I'll spare you that backtrace, Stefan. ;)
Great! Now, for some extra brownie points and our eternal gratitude: a unit test?
Stéfan
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
On Thu, Apr 18, 2013 at 5:12 PM, Zachary Pincus <zachary.pincus@yale.edu> wrote:
Also, BTW, I get the below test failure when I have matplotlib but no PIL installed. I think test_imread_url or the test right before it must be making some incorrect assumptions. (If I re-run the tests after this failure, then also all of the tifffile tests fail, so it seems that some test isn't doing proper teardown of the image loading plugins?)
That's quite possible--can you see how to fix that test as well? Stéfan
OK, unittest added: https://github.com/scikit-image/scikit-image/pull/508
Aaaaannndd now Travis says I broke the build?? This is what I get! https://travis-ci.org/scikit-image/scikit-image/builds/6447268 But, umm, here's the offending portion of the build log:
$ rake rake aborted! No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb) (See full trace by running task with --trace) The command "rake" exited with 1. Done. Your build exited with 1.
I don't think I know what I did (if anything) to provoke this...
On Thu, Apr 18, 2013 at 5:21 PM, Zachary Pincus <zachary.pincus@yale.edu> wrote:
I don't think I know what I did (if anything) to provoke this...
Nope! Not your fault. In these situations, doing another push or close/open or rebase will all re-trigger the tests. Stéfan
On Thu, Apr 18, 2013 at 5:12 PM, Zachary Pincus <zachary.pincus@yale.edu> wrote:
Also, BTW, I get the below test failure when I have matplotlib but no PIL installed. I think test_imread_url or the test right before it must be making some incorrect assumptions. (If I re-run the tests after this failure, then also all of the tifffile tests fail, so it seems that some test isn't doing proper teardown of the image loading plugins?)
Ah, I see what's happening. This one might be a job for @tonysyu -- Tony, this looks weird because matplotlib is supposed to be able to handle pngs (and you are reading in a png in that test). So perhaps a bug in matplotlib when providing a "file-like object"? Stéfan
participants (2)
-
Stéfan van der Walt -
Zachary Pincus