What is the reference implementation in this case? Scipy?
On Nov 19, 2014, at 10:43 PM, Juan Nunez-Iglesias <jni.soma@gmail.com> wrote:
Is it what the "reference" implementation returns? Either way the sign is valuable info. +1 for returning the actual filter output.
On Thu, Nov 20, 2014 at 11:25 AM, Johannes Schoenberger <jsch@demuc.de> wrote: Hi,
Why are we returning the absolute values in the hsobel and vsobel functions?
I do not see the benefit.
Johannes
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
How do we want to treat this change in behavior? Raise a warning?
On Nov 19, 2014, at 10:45 PM, Johannes Schoenberger <jsch@demuc.de> wrote:
What is the reference implementation in this case? Scipy?
On Nov 19, 2014, at 10:43 PM, Juan Nunez-Iglesias <jni.soma@gmail.com> wrote:
Is it what the "reference" implementation returns? Either way the sign is valuable info. +1 for returning the actual filter output.
On Thu, Nov 20, 2014 at 11:25 AM, Johannes Schoenberger <jsch@demuc.de> wrote: Hi,
Why are we returning the absolute values in the hsobel and vsobel functions?
I do not see the benefit.
Johannes
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
+1 on the change. This caused problems for the SciPy 2014 tutorial and required switching to the scipy implementation. One option would be to create new functions; e.g. `sobel_h`/`sobel_v` (or `sobel_x`/`sobel_y`; in this case, it might make sense to match x/y with the gradient direction rather than the edge direction). Alternatively, we might consider adding a warning and a `deprecation_warning=True` flag to `hsobel`/`vsobel`. That way, users can adapt to the change (if necessary) and turn off the deprecation warning. -Tony On Wed, Nov 19, 2014 at 9:53 PM, Johannes Schoenberger <jsch@demuc.de> wrote:
How do we want to treat this change in behavior? Raise a warning?
On Nov 19, 2014, at 10:45 PM, Johannes Schoenberger <jsch@demuc.de> wrote:
What is the reference implementation in this case? Scipy?
On Nov 19, 2014, at 10:43 PM, Juan Nunez-Iglesias <jni.soma@gmail.com> wrote:
Is it what the "reference" implementation returns? Either way the sign is valuable info. +1 for returning the actual filter output.
On Thu, Nov 20, 2014 at 11:25 AM, Johannes Schoenberger <jsch@demuc.de> wrote: Hi,
Why are we returning the absolute values in the hsobel and vsobel functions?
I do not see the benefit.
Johannes
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "scikit-image" group. To unsubscribe from this group and stop receiving emails from it, send an email to scikit-image+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
participants (2)
-
Johannes Schoenberger -
Tony Yu