On Nov 12, 2009, at 3:37 PM, Stéfan van der Walt wrote:

Hi Tony

2009/11/12 Tony S Yu <tsyu80@gmail.com>:

...

I've uploaded a fix to remove the dependency on enhanced decorators.

I just tested @property decorators under 2.5 and they seem to work -- could you describe the problem you are having?

Hey Stefan, In io.collections, the setter for as_grey is defined with `@as_grey.setter`. 2.5 allows @property, but not @property.setter.

I did fix a "with ..." that slipped in.

...

Also, I noticed that the doctests in the io package are not really maintained. I fixed some file loading issues in my "io_doctest" branch. One test still fails because I'm not sure how to rewrite it without making it really ugly (the test prints out the filepaths in a collection, but you want to test the filename). Also, a doctest for io.show fails because there's no default plugin showing images.

Thanks for pointing out these problems. They should be fixed in the master branch.

Thanks for you quick response. I see that you made changes to the "show" doctest. Nevertheless, the test still fails on my system because there's no plugin specified for imshow when I run the test. (If I specify, io.use_plugin and import numpy as np, it sort of works; no really b/c it registers a failure since imshow returns objects that the doctest checks). I'm not sure if it makes sense to write that example as a doctest (because of these complications). Cheers -Tony

Cheers Stéfan

On Nov 12, 2009, at 4:24 PM, Stéfan van der Walt wrote:

2009/11/12 Tony S Yu <tsyu80@gmail.com>:

...

Thanks for you quick response. I see that you made changes to the "show" doctest. Nevertheless, the test still fails on my system because there's no plugin specified for imshow when I run the test. (If I specify, io.use_plugin and import numpy as np, it sort of works; no really b/c it registers a failure since imshow returns objects that the doctest checks). I'm not sure if it makes sense to write that example as a doctest (because of these complications).

Did you reinstall the scikit?

Good point! I was just looking at the commits and copied and pasted the stuff you added in the "fix doctests" commit. The null plugin works as you describe after pull the your latest revisions. Thanks, -Tony

I added a "null" plugin that should be used by default. You should see something like:

In [7]: io.plugins(loaded=True) Out[7]: {'null': ['imshow'], 'pil': ['imread', 'imsave']}

Cheers Stéfan

Received from Stéfan van der Walt on Fri, Nov 13, 2009 at 07:57:09PM EST:

Hi Lev

2009/11/13 Lev Givon <lev@columbia.edu>:

...

When I tried to build the html documentation, I observed the following error:

Thanks for the bug report. I have put new source distribution at

http://pypi.python.org/pypi/scikits.image

that should fix the problem.

Regards Stéfan

Thanks for the quick fix. One other small item: it seems that installing the package causes the setup.py files in the source directory tree to be installed: /usr/lib/python2.6/site-packages/scikits/image/graph/setup.py /usr/lib/python2.6/site-packages/scikits/image/graph/setup.pyc /usr/lib/python2.6/site-packages/scikits/image/io/setup.py /usr/lib/python2.6/site-packages/scikits/image/io/setup.pyc /usr/lib/python2.6/site-packages/scikits/image/opencv/setup.py /usr/lib/python2.6/site-packages/scikits/image/opencv/setup.pyc /usr/lib/python2.6/site-packages/scikits/image/setup.py /usr/lib/python2.6/site-packages/scikits/image/setup.pyc L.G.