
Hey Zach Can you believe it! I've merged your changes and pushed to github. Thanks Stéfan On 9 April 2010 00:19, Zachary Pincus <zachary.pincus@yale.edu> wrote:
Hi Stéfan,
I noticed a huge performance decrease in the performance of the graph algorithms in scikits.image when I installed from your repository on a new lab computer; I tracked it down to a fix you made in heap.pyx to prevent newer versions of cython from barfing on lines like: ii = (i-1)/2 # CalcPrevAbs For some reason, the change to: ii = (int)(i-1)/2 # CalcPrevAbs forces the use of the python division machinery! I think this is a "feature" (to ape "from __future__ import division" I think), but what a gotcha! I fixed it as: ii = (i-1)//2 # CalcPrevAbs
Anyhow, if you pull from heap-perf on http://github.com/zachrahan/scikits.image , you'll get the fix (and an additional correctness issue elsewhere in mcp.)
Zach
participants (1)
-
Stéfan van der Walt