Mailman 3 May 2022 - Scikit-learn-commits

[scikit-learn/scikit-learn] 4b6273: ENH Native support for missing values in GBDTs (#1...
by Nicolas Hug 16 Jul '24

16 Jul '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 4b6273b87442a4437d8b3873ea3022ae163f4fdf https://github.com/scikit-learn/scikit-learn/commit/4b6273b87442a4437d8b387… Author: Nicolas Hug <contact(a)nicolas-hug.com> Date: 2019-08-21 (Wed, 21 Aug 2019) Changed paths: M benchmarks/bench_hist_gradient_boosting.py M doc/modules/ensemble.rst M doc/whats_new/v0.22.rst M sklearn/ensemble/_hist_gradient_boosting/_binning.pyx M sklearn/ensemble/_hist_gradient_boosting/_gradient_boosting.pyx M sklearn/ensemble/_hist_gradient_boosting/_loss.pyx M sklearn/ensemble/_hist_gradient_boosting/_predictor.pyx M sklearn/ensemble/_hist_gradient_boosting/binning.py A sklearn/ensemble/_hist_gradient_boosting/common.pxd A sklearn/ensemble/_hist_gradient_boosting/common.pyx M sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py M sklearn/ensemble/_hist_gradient_boosting/grower.py M sklearn/ensemble/_hist_gradient_boosting/histogram.pyx M sklearn/ensemble/_hist_gradient_boosting/loss.py M sklearn/ensemble/_hist_gradient_boosting/predictor.py M sklearn/ensemble/_hist_gradient_boosting/splitting.pyx M sklearn/ensemble/_hist_gradient_boosting/tests/test_binning.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_compare_lightgbm.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_gradient_boosting.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_grower.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_histogram.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_loss.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_predictor.py M sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py R sklearn/ensemble/_hist_gradient_boosting/types.pxd R sklearn/ensemble/_hist_gradient_boosting/types.pyx M sklearn/ensemble/_hist_gradient_boosting/utils.pyx M sklearn/ensemble/setup.py Log Message: ----------- ENH Native support for missing values in GBDTs (#13911) * Added NaN support in mapper * pep * WIP * some more * WIP * WIP * bug fix * basic tests * some doc * avoid some interactions * Added tag * better test * decent test + fix bug * add missing_fraction param to benchmark * bin training and validation data separately * shorter test * Map missing values to first bin instead of last * pep8 * Added whats new entry * avoid some python interactions * make predict_binned work * fixed bug due to offset in bin_thresholds_ attribute * more sensible binning strat * typo * user name * Add small test * convert to fortran array in tests * some doc * Added function test * pep8 * Bin validation data using binmaper of training data * Allocate first bin for missing entries based on the whole data, not just training data. * Addressed Thomas' comments * Update sklearn/ensemble/_hist_gradient_boosting/tests/test_grower.py * Addressed Guillaume's comments * always allocate first bin for missing values * reduce diff * minor more consistent test * typo * WIP * some doc * reduce diff * pep8 * minor * remove prints * towards nan only splits * don't check right to left on split_on_nan * cleaups * format and comment * Fixed bug + added more tests * refactor tests * put back n_threads to max value * minor changes * minor cleaning * Add (failing) test that checks equivalence with min max imputation * Decrease the likelihood of ties when training the trees * More robust test * Fix pytest parametrization * Check bin thresholds in test * Try to make the test even easier to see if the Linux 32bit build would pass in this case * Don't check last non-missing bin if there's no nan * Improve min-max imputation test * FIX: _find_best_bin_to_split_right_to_left is still required even when left to right wants to split on nans * comments * remove split_on_nan * ooops deleted useless files * Got rid of individual checks in predictor code +inf thresholds are only allowed in a split on nan situation. Thresholds that are computed as +inf are capped to a very high constant value * can also remove special case in binning code * minor typos + more consistent test * renamed types -> common * 1e300 -> almost inf * added user guide section on missing values * Addressed Olivier's comment + updated whatsnew * addressed comments * Fix doctest formatting * Fix nan predictive doctest

14 18

[scikit-learn/scikit-learn] 91badf: DOC Format docstrings in _coordinate_descent.py (#...
by Hirofumi Suzuki 04 Jul '24

04 Jul '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 91badfab662ad1eafda4b60d078f563f010265cc https://github.com/scikit-learn/scikit-learn/commit/91badfab662ad1eafda4b60… Author: Hirofumi Suzuki <hs-nazuna(a)users.noreply.github.com> Date: 2020-01-30 (Thu, 30 Jan 2020) Changed paths: M sklearn/linear_model/_coordinate_descent.py Log Message: ----------- DOC Format docstrings in _coordinate_descent.py (#16285)

5 5

[scikit-learn/scikit-learn] e1c764: DOC Cleaning parameter spec in docstrings of base ...
by lopusz 10 Jun '24

10 Jun '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: e1c7649469eb91c4a23796717b58da266345ab8e https://github.com/scikit-learn/scikit-learn/commit/e1c7649469eb91c4a237967… Author: lopusz <lopusz(a)users.noreply.github.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M sklearn/base.py Log Message: ----------- DOC Cleaning parameter spec in docstrings of base module (#16284)

7 7

[scikit-learn/scikit-learn] c664df: DOC ensure all attributes are documented for RBFSa...
by judithabk6 10 Jun '24

10 Jun '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: c664df47cc273ebc143a877825479a4f95f83db2 https://github.com/scikit-learn/scikit-learn/commit/c664df47cc273ebc143a877… Author: judithabk6 <judithabk6(a)users.noreply.github.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M sklearn/kernel_approximation.py Log Message: ----------- DOC ensure all attributes are documented for RBFSampler (#16276)

10 11

[scikit-learn/scikit-learn] 86f47d: Fix warning in approximate_nearest_neighbors.py (#...
by Hirofumi Suzuki 06 Jun '24

06 Jun '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 86f47da52954cb68b5eb17ffcc909194e31bbaee https://github.com/scikit-learn/scikit-learn/commit/86f47da52954cb68b5eb17f… Author: Hirofumi Suzuki <hs-nazuna(a)users.noreply.github.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M examples/neighbors/approximate_nearest_neighbors.py Log Message: ----------- Fix warning in approximate_nearest_neighbors.py (#16339)

11 10

[scikit-learn/scikit-learn] e05b9e: MNT Comment out instructions in bug report templat...
by Thomas J Fan 29 May '24

29 May '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: e05b9e146006236aa41349105e8a01ac9535fba7 https://github.com/scikit-learn/scikit-learn/commit/e05b9e146006236aa413491… Author: Thomas J Fan <thomasjpfan(a)gmail.com> Date: 2020-01-30 (Thu, 30 Jan 2020) Changed paths: M .github/ISSUE_TEMPLATE/bug_report.md Log Message: ----------- MNT Comment out instructions in bug report template (#16325)

5 4

[scikit-learn/scikit-learn] 3743a5: Fix: Possible unnecessary iterations in Newton-CG ...
by Rushabh Vasani 29 May '24

29 May '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 3743a55aed5c9ee18c8b94b95dfc4c41d0ae99f5 https://github.com/scikit-learn/scikit-learn/commit/3743a55aed5c9ee18c8b94b… Author: Rushabh Vasani <vasanirushabh24(a)gmail.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M doc/whats_new/v0.23.rst M sklearn/utils/optimize.py Log Message: ----------- Fix: Possible unnecessary iterations in Newton-CG algorithm (#16266)

4 3

[scikit-learn/scikit-learn] 70829b: MNT Small check sample weight refactor (#16324)
by Thomas J Fan 29 May '24

29 May '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 70829b34df8a1d98a15250f041102c6c0b10e2d1 https://github.com/scikit-learn/scikit-learn/commit/70829b34df8a1d98a15250f… Author: Thomas J Fan <thomasjpfan(a)gmail.com> Date: 2020-01-30 (Thu, 30 Jan 2020) Changed paths: M sklearn/utils/validation.py Log Message: ----------- MNT Small check sample weight refactor (#16324)

5 4

[scikit-learn/scikit-learn] 83985e: DOC Sort estimator tags in alphabetical order (#16...
by Sebastian Kießling 29 May '24

29 May '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: 83985e9fe82d22ae984a09282d82a6a8dbcbaa9a https://github.com/scikit-learn/scikit-learn/commit/83985e9fe82d22ae984a092… Author: Sebastian Kießling <sebkies(a)gmail.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M doc/developers/develop.rst Log Message: ----------- DOC Sort estimator tags in alphabetical order (#16334)

7 6

[scikit-learn/scikit-learn] ccc81c: DOC Improve random_state descriptions for Gradient...
by Pierre Delanoue 09 May '24

09 May '24

Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: ccc81cc3a90ea1080c2d03c3a12fd638325da792 https://github.com/scikit-learn/scikit-learn/commit/ccc81cc3a90ea1080c2d03c… Author: Pierre Delanoue <delanoue.pierre(a)gmail.com> Date: 2020-01-31 (Fri, 31 Jan 2020) Changed paths: M sklearn/ensemble/_gb.py Log Message: ----------- DOC Improve random_state descriptions for GradientBoosting (#16314)

6 5