[scikit-learn/scikit-learn] f15ebb: [MRG] Convert ColumnTransformer input list to nump...
![](https://secure.gravatar.com/avatar/9181eb84f9c35729a3bad740fb7f9d93.jpg?s=120&d=mm&r=g)
Branch: refs/heads/master Home: https://github.com/scikit-learn/scikit-learn Commit: f15ebb953b7b8971093962514187f447df4c716c https://github.com/scikit-learn/scikit-learn/commit/f15ebb953b7b897109396251... Author: Vinayak Mehta <vmehta94@gmail.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M sklearn/compose/_column_transformer.py M sklearn/compose/tests/test_column_transformer.py Log Message: ----------- [MRG] Convert ColumnTransformer input list to numpy array (#12104) <!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pul... --> #### Reference Issues/PRs <!-- Example: Fixes #1234. See also #3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> Fixes #12096. #### What does this implement/fix? Explain your changes. Converts the input list for ColumnTransformer to a numpy array. Added a check inside `transform` and `fit_transform` to check if the input `X` is a list, if it is then it gets converted to a numpy array. #### Any other comments? Should this conversion be documented in the docstrings for ColumnTransfomer's `fit`, `transform` and `fit_transform`? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-.... Thanks for contributing! --> **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
participants (1)
-
GitHub