Thanks for the clarification. On Fri, Jan 24, 2020 at 3:42 AM Adrin <adrin.jalali@gmail.com> wrote:
Hi Madhura,
We don't really follow the assignment workflow. Whichever of the maintainers is free and feels like reviewing the PR will do so. But in general review time is our main bottleneck, and it may take some time for us to get on a PR.
Patience and every now and then writing a comment under your PR saying "a gentle ping" or something would probably remind us that it's still not reviewed :)
Thanks for contributing, Adrin.
On Thu, Jan 23, 2020 at 6:33 AM Madhura Jayaratne <madhura.cj@gmail.com> wrote:
Hi Scikit-learn team,
I have submitted a PR implementing support for ICE plots at [1]. There I noticed that Github suggests reviewers based on the recent edits and reviews to the files changed in the PR. I am wondering what is the preferred practice for assigning reviewers. (Initially, I assigned Guillaume Lemaitre without thinking much, but he cannot review at the moment) I am wondering, should I assign someone from the suggested list or should I wait for the core developers to assign themselves?
[1] https://github.com/scikit-learn/scikit-learn/pull/16164
-- Thanks and Regards,
Madhura Jayaratne
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
-- Thanks and Regards, Madhura Jayaratne