Hi Ilya. You can raise an issue with multiple minor problems, or you can just send a PR. We don't really like to do many cosmetic fixes, because they tend to create merge conflicts. But for semantic changes, like avoiding an array copy, we're very happy about any improvements. You can totally pack multiple one-line changes into a single PR if they are all simple to review. One thing to keep in mind: the shorter the PR, the faster the review and merge ;) Andy On 08/30/2016 03:19 PM, Ilya Persky wrote:

Hi All!

I'm now reading scikit-learn source code and sometimes meet minor inconsistencies here and there like unnecessary copying of some array or some very unimportant race condition. Nothing like serious bug really.

What should I do about it? Create an issue for each case would be an overkill. Create an issue for all of them and add pull request with fixes? Or first send a letter with them here?..

Again I'm new to this code and can be easily missing something (something looking like minor bug could appear to be a feature :) ).

-- Thank you, Ilya.

_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn