Hi Developers, I am new to scikit-learn and want some guidance to start contributing to it. I am well versed with python and c/c++. Linux user. Can anyone help me get me going. Regards, *Sagar Kar* P: +91-9085986905 W: sagarkar10.github.io
The best thing to do is to read the contributors documentation, and then get started with an issue labelled easy. Cheers, Gaël
Thanks Gael, I read it. But I am having hard time finding an issue to work on. Frankly, I am unable to understand how to approach the easy issues also. Sorry for being naive. Regards, *Sagar Kar* P: +91-9085986905 W: sagarkar10.github.io On Sat, Jun 18, 2016 at 2:48 PM, Gael Varoquaux < gael.varoquaux@normalesup.org> wrote:
The best thing to do is to read the contributors documentation, and then get started with an issue labelled easy.
Cheers,
Gaël _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
You can also try one, and if you are stuck, just ask for help. Someone should be able to help you out ;) 2016-06-18 10:33 GMT+01:00 Sagar Kar <sagarkar10@gmail.com>:
Thanks Gael, I read it. But I am having hard time finding an issue to work on. Frankly, I am unable to understand how to approach the easy issues also. Sorry for being naive.
Regards, *Sagar Kar* P: +91-9085986905 W: sagarkar10.github.io
On Sat, Jun 18, 2016 at 2:48 PM, Gael Varoquaux < gael.varoquaux@normalesup.org> wrote:
The best thing to do is to read the contributors documentation, and then get started with an issue labelled easy.
Cheers,
Gaël _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
-- Information System Engineer, Ph.D. Blog: http://blog.audio-tk.com/ LinkedIn: http://www.linkedin.com/in/matthieubrucher
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it. Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 months ago, and they are relatively useful :), but they wasn't reviewed. Some of them are quite simple for review (~10 lines in python), and still have only 1 vote. Maybe it's possible to increase size of team which have permission to review? Or all I can do is just wait? :) I'm writing this letter because yesterday one guy complained about this in one of my PR's (I forgot about that PR by the time) https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-22704422....
The review process has always been quite slow; the only thing you can do is ping and try to fix things on your side as quickly as possible. There are a lot of PRs in development at any one time, and it's difficult for the reviewers (let alone the contributors, as you mentioned) to keep track of everything that's being done. If you find that no one has looked at your code in awhile, I'd ping some of the core contributors. Also see: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-... On Mon, Jun 20, 2016 at 9:10 PM olologin <olologin@gmail.com> wrote:
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it.
Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 months ago, and they are relatively useful :), but they wasn't reviewed. Some of them are quite simple for review (~10 lines in python), and still have only 1 vote. Maybe it's possible to increase size of team which have permission to review? Or all I can do is just wait? :)
I'm writing this letter because yesterday one guy complained about this in one of my PR's (I forgot about that PR by the time)
https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-22704422... . _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
I think perhaps that FAQ should be updated to say "nag if needed"! Apologies for that delay, @olologin. Yes, it would be good if we had a better way of organising reviewing priorities, but between github's feature set and the distributed nature of the core dev team, we land up relying on chance, or a developer being interested in a particular feature. Again, nagging helps. On 21 June 2016 at 14:17, Nelson Liu <nfliu@uw.edu> wrote:
The review process has always been quite slow; the only thing you can do is ping and try to fix things on your side as quickly as possible. There are a lot of PRs in development at any one time, and it's difficult for the reviewers (let alone the contributors, as you mentioned) to keep track of everything that's being done. If you find that no one has looked at your code in awhile, I'd ping some of the core contributors. Also see: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-...
On Mon, Jun 20, 2016 at 9:10 PM olologin <olologin@gmail.com> wrote:
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it.
Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 months ago, and they are relatively useful :), but they wasn't reviewed. Some of them are quite simple for review (~10 lines in python), and still have only 1 vote. Maybe it's possible to increase size of team which have permission to review? Or all I can do is just wait? :)
I'm writing this letter because yesterday one guy complained about this in one of my PR's (I forgot about that PR by the time)
https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-22704422... . _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
Sorry, I've been off review duty for a while, should be back later this summer ;) On 06/21/2016 12:09 AM, olologin wrote:
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it.
Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 months ago, and they are relatively useful :), but they wasn't reviewed. Some of them are quite simple for review (~10 lines in python), and still have only 1 vote. Maybe it's possible to increase size of team which have permission to review? Or all I can do is just wait? :)
I'm writing this letter because yesterday one guy complained about this in one of my PR's (I forgot about that PR by the time) https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-22704422.... _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
"nag if needed"!
I always assume it to be an implicit advice ;P On Wed, Jun 22, 2016 at 9:39 PM, Andreas Mueller <t3kcit@gmail.com> wrote:
Sorry, I've been off review duty for a while, should be back later this summer ;)
On 06/21/2016 12:09 AM, olologin wrote:
Hi guys, I know scikit-learn may not be your main project, and you all are very busy at work so you don't have free time to review all pull requests, I understand it.
Is there something project leaders can do to speed-up review process? Because I have bunch of pull requests which I made 5-7 months ago, and they are relatively useful :), but they wasn't reviewed. Some of them are quite simple for review (~10 lines in python), and still have only 1 vote. Maybe it's possible to increase size of team which have permission to review? Or all I can do is just wait? :)
I'm writing this letter because yesterday one guy complained about this in one of my PR's (I forgot about that PR by the time) https://github.com/scikit-learn/scikit-learn/pull/6116#issuecomment-22704422... . _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
Reg. the "Needs Review" tag - Could I request the maintainers to unlabel the PR once a review has been completed and is waiting for the author? (Should filter out a lot of noise). The use case I envision for this tag would be to serve as a bookmark or a green flag to the maintainer who labels it so he could revisit later or other maintainers who might have time to look into that PR. Currently all PRs with `[MRG.*]` are labelled with this (~90) and many of them are waiting for the author to respond back. Also I feel it would be useful to have a second label (like Manoj suggested in a previous thread) to separate those PR which needs to be reviewed in detail from those which just needs a second look. (read as - a label used by Maintainer A to signal any other Maintainer who can spare a few minutes to take a glance and merge). Maybe "Needs Quick Review" / "Needs 2nd Review"?. Same for the "Need Contributors" tag. Should be untagged once someone raises a PR. (A lot of new contributors have complained that those issues marked "Need Contributors" are taken. I know I am responsible for 2 such issues :P But I've also asked the commenter to go ahead and raise a PR in both cases.) On Thu, Jun 23, 2016 at 2:51 PM, Joel Nothman <joel.nothman@gmail.com> wrote:
On 23 June 2016 at 22:47, Raghav R V <ragvrv@gmail.com> wrote:
"nag if needed"!
I always assume it to be an implicit advice ;P
I could tell.
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
participants (8)
-
Andreas Mueller -
Gael Varoquaux -
Joel Nothman -
Matthieu Brucher -
Nelson Liu -
olologin -
Raghav R V -
Sagar Kar