Bookmarklet to view documentation on CircleCI
At https://gist.github.com/jnothman/bf76d02f60af6476221ec65c63c77e60 I've created a bookmarklet which, when viewing a pull request page for which the CircleCI build has finished, will identify the circle build number and open a new tab with the changed documentation files corresponding to that PR.
I hope it's useful to someone else. On 21 December 2016 at 21:03, Joel Nothman <joel.nothman@gmail.com> wrote:
At https://gist.github.com/jnothman/bf76d02f60af6476221ec65c63c77e60 I've created a bookmarklet which, when viewing a pull request page for which the CircleCI build has finished, will identify the circle build number and open a new tab with the changed documentation files corresponding to that PR.
This is great, thanks for sharing Joel! On Wed, Dec 21, 2016 at 12:08 AM Joel Nothman <joel.nothman@gmail.com> wrote:
I hope it's useful to someone else.
On 21 December 2016 at 21:03, Joel Nothman <joel.nothman@gmail.com> wrote:
At https://gist.github.com/jnothman/bf76d02f60af6476221ec65c63c77e60 I've created a bookmarklet which, when viewing a pull request page for which the CircleCI build has finished, will identify the circle build number and open a new tab with the changed documentation files corresponding to that PR.
_______________________________________________
scikit-learn mailing list
scikit-learn@python.org
It's super neat. It's a pity that I don't see a way of integrating it to the github interface. Gaël On Wed, Dec 21, 2016 at 09:03:59PM +1100, Joel Nothman wrote:
I hope it's useful to someone else.
On 21 December 2016 at 21:03, Joel Nothman <joel.nothman@gmail.com> wrote:
At https://gist.github.com/jnothman/bf76d02f60af6476221ec65c63c77e60 I've created a bookmarklet which, when viewing a pull request page for which the CircleCI build has finished, will identify the circle build number and open a new tab with the changed documentation files corresponding to that PR.
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
-- Gael Varoquaux Researcher, INRIA Parietal NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France Phone: ++ 33-1-69-08-79-68 http://gael-varoquaux.info http://twitter.com/GaelVaroquaux
Well, you can as a browser extension. I just haven't bothered to investigate that technology when there's so much code to review and write. On 22 December 2016 at 09:33, Gael Varoquaux <gael.varoquaux@normalesup.org> wrote:
It's super neat. It's a pity that I don't see a way of integrating it to the github interface.
Gaël
On Wed, Dec 21, 2016 at 09:03:59PM +1100, Joel Nothman wrote:
I hope it's useful to someone else.
On 21 December 2016 at 21:03, Joel Nothman <joel.nothman@gmail.com> wrote:
At https://gist.github.com/jnothman/bf76d02f60af6476221ec65c63c77e60
I've
created a bookmarklet which, when viewing a pull request page for
which the
CircleCI build has finished, will identify the circle build number
and open
a new tab with the changed documentation files corresponding to that
PR.
_______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
-- Gael Varoquaux Researcher, INRIA Parietal NeuroSpin/CEA Saclay , Bat 145, 91191 Gif-sur-Yvette France Phone: ++ 33-1-69-08-79-68 http://gael-varoquaux.info http://twitter.com/GaelVaroquaux _______________________________________________ scikit-learn mailing list scikit-learn@python.org https://mail.python.org/mailman/listinfo/scikit-learn
On 12/21/2016 07:48 PM, Joel Nothman wrote:
Well, you can as a browser extension. I just haven't bothered to investigate that technology when there's so much code to review and write.
Can you post it to the docs or maybe more appropriately to the wiki where it's easier to discover and link to?
On 12/22/2016 01:48 AM, Joel Nothman wrote:
Well, you can as a browser extension. I just haven't bothered to investigate that technology when there's so much code to review and write.
On 22 December 2016 at 09:33, Gael Varoquaux <gael.varoquaux@normalesup.org <mailto:gael.varoquaux@normalesup.org>> wrote:
It's super neat. It's a pity that I don't see a way of integrating it to the github interface.
I bit the bullet today and created a Userscript for Greasemonkey (on Chrome you can apparently use Tampermonkey) to add a button to the PR (at the moment right of the "Edit" button to edit the title) that pretty does the same thing as the bookmarklet. A snapshot is attached for clarity. This link to the raw gist should install it in your Greasemonkey user scripts: https://gist.github.com/lesteve/470170f288884ec052bcf4bc4ffe958a/raw/4270d0c... Any comments/improvements, let me know. At the moment the button is only showed in the "Conversation" tab. Also note that for some reason that are beyond my web skills you may need to refresh the page to see the button, e.g. if you go first to https://github.com/scikit-learn/scikit-learn/pull/7995/files and then click on the "Conversation" page. It seems like the 'load' event is not triggered. Cheers, Loïc
On 12/22/2016 01:48 AM, Joel Nothman wrote:
Well, you can as a browser extension. I just haven't bothered to investigate that technology when there's so much code to review and write.
On 22 December 2016 at 09:33, Gael Varoquaux <gael.varoquaux@normalesup.org <mailto:gael.varoquaux@normalesup.org>> wrote:
It's super neat. It's a pity that I don't see a way of integrating it to the github interface.
I bit the bullet today and created a Userscript for Greasemonkey (on Chrome you can apparently use Tampermonkey) to add a button to the PR (at the moment right of the "Edit" button to edit the title) that pretty does the same thing as the bookmarklet. A snapshot is attached for clarity. This link to the raw gist should install it in your Greasemonkey user scripts: https://gist.github.com/lesteve/470170f288884ec052bcf4bc4ffe958a/raw/4270d0c... Any comments/improvements, let me know. At the moment the button is only showed in the "Conversation" tab. Also note that for some reason that are beyond my web skills you may need to refresh the page to see the button, e.g. if you go first to https://github.com/scikit-learn/scikit-learn/pull/7995/files and then click on the "Conversation" page. It seems like the 'load' event is not triggered. Cheers, Loïc
On 12/22/2016 01:48 AM, Joel Nothman wrote:
Well, you can as a browser extension. I just haven't bothered to investigate that technology when there's so much code to review and write.
On 22 December 2016 at 09:33, Gael Varoquaux <gael.varoquaux@normalesup.org <mailto:gael.varoquaux@normalesup.org>> wrote:
It's super neat. It's a pity that I don't see a way of integrating it to the github interface.
I bit the bullet today and created a Userscript for Greasemonkey (on Chrome you can apparently use Tampermonkey) to add a button to the PR (at the moment right of the "Edit" button to edit the title) that pretty does the same thing as the bookmarklet. A snapshot is attached for clarity. This link to the raw gist should install it in your Greasemonkey user scripts: https://gist.github.com/lesteve/470170f288884ec052bcf4bc4ffe958a/raw/4270d0c... Any comments/improvements, let me know. At the moment the button is only showed in the "Conversation" tab. Also note that for some reason that are beyond my web skills you may need to refresh the page to see the button, e.g. if you go first to https://github.com/scikit-learn/scikit-learn/pull/7995/files and then click on the "Conversation" page. It seems like the 'load' event is not triggered. Cheers, Loïc
participants (5)
-
Andy -
Gael Varoquaux -
Joel Nothman -
Loïc Estève -
Nelson Liu