Great work ! I could not resists and I had to test it. From my (naive) visual tests, it seems pretty good but I'm not a specialist: http://www.labri.fr/perso/nrougier/tmp/spherical-voronoi-1.png http://www.labri.fr/perso/nrougier/tmp/spherical-voronoi-2.png I tried different sizes (screenshots above use 5000 points) but not the degenerate cases. (Sources available from glumpy: https://github.com/glumpy/glumpy/blob/master/examples/spherical-voronoi.py) Nicolas
On 14 Feb 2016, at 17:43, Tyler Reddy <tyler.je.reddy@gmail.com> wrote:
Hello,
Nikolai and I have done the best we can with this pull request (https://github.com/scipy/scipy/pull/5232). As it adds an entirely new functionality, an extra set of eyes to look it over would be much appreciated. The test coverage is > 90% and a large number of maintainer requests have been satisfied since Sept. 2015.
One of the biggest challenges with the spherical Voronoi diagram on a sphere algorithm addition is the apparent lack of open source alternative implementations--this simultaneously increases the value of the contribution and makes it more difficult to verify its quality.
Also, I think the mailing list may have been having issues when the initial emails were sent out.
Thanks a lot! Tyler _______________________________________________ SciPy-Dev mailing list SciPy-Dev@scipy.org https://mail.scipy.org/mailman/listinfo/scipy-dev